[pve-devel] [PATCH installer] run env: always re-create run env file in test mode

[pve-devel] [PATCH installer] run env: always re-create run env file in test mode

[Christoph Heiss]

When debugging or otherwise deliberately running the `dump-env`
low-level installer command in test mode, chances are that you'd want
the run env file to be re-created as well.

No impact on the normal installation flow.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Noticed over time that I have to run
`rm [..]/run/proxmox-installer/run-env-info.json` way to often. Also,
the fact that this file is cached is probably not that obvious to anyone
who doesn't know the installer by heart.

 Proxmox/Install/RunEnv.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm
index 9878f55..19b5387 100644
--- a/Proxmox/Install/RunEnv.pm
+++ b/Proxmox/Install/RunEnv.pm
@@ -241,7 +241,7 @@ my sub detect_country_tracing_to : prototype($$) {
 sub query_installation_environment : prototype() {
     # check first if somebody already cached this for us and re-use that
     my $run_env_file = Proxmox::Install::ISOEnv::get('run-env-cache-file');
-    if (-f "$run_env_file") {
+    if (-f "$run_env_file" && !Proxmox::Install::ISOEnv::is_test_mode()) {
 	log_info("re-using cached runtime env from $run_env_file");
 	my $cached_env = eval {
 	    my $run_env_raw = Proxmox::Sys::File::file_read_all($run_env_file);
--
2.42.0

[pve-devel] applied: [PATCH installer] run env: always re-create run env file in test mode

[Thomas Lamprecht]

Am 18.10.23 um 10:17 schrieb Christoph Heiss:
> When debugging or otherwise deliberately running the `dump-env`
> low-level installer command in test mode, chances are that you'd want
> the run env file to be re-created as well.
> 
> No impact on the normal installation flow.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Noticed over time that I have to run
> `rm [..]/run/proxmox-installer/run-env-info.json` way to often. Also,
> the fact that this file is cached is probably not that obvious to anyone
> who doesn't know the installer by heart.
> 
>  Proxmox/Install/RunEnv.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel