all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager 2/2] ui: CephInstall: fix a/an typo
Date: Wed, 7 Sep 2022 15:28:30 +0200	[thread overview]
Message-ID: <06e9583f-e34a-8599-eaa2-930f159b6e97@proxmox.com> (raw)
In-Reply-To: <20220810151020.573769-2-a.lauterer@proxmox.com>

Am 10/08/2022 um 17:10 schrieb Aaron Lauterer:
> and switch to template string
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> the spaces should still be where we need them due to the string being
> multi line.
> 
> if we don't want to use them like this, drop this patch, but please fix
> the a/an typo :)

just sent the typo fix instead next time?! If you really want to move
existing code to template string (not much valueadd in this case) do
so in a follow up fix after fixing the typo as those things are semantically
completely unrelated, iow. two patches.

> 
>  www/manager6/window/CephInstall.js | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>

applied, thanks!




  reply	other threads:[~2022-09-07 13:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10 15:10 [pve-devel] [PATCH manager 1/2] ui: CephInstallWizard: make first mon node static Aaron Lauterer
2022-08-10 15:10 ` [pve-devel] [PATCH manager 2/2] ui: CephInstall: fix a/an typo Aaron Lauterer
2022-09-07 13:28   ` Thomas Lamprecht [this message]
2022-09-07 13:26 ` [pve-devel] applied: [PATCH manager 1/2] ui: CephInstallWizard: make first mon node static Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06e9583f-e34a-8599-eaa2-930f159b6e97@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal