From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager 1/2] ui: FirewallRules: make columns flexible
Date: Mon, 22 Feb 2021 14:40:10 +0100 [thread overview]
Message-ID: <06c826b2-3524-86ed-a4cd-c8bcfbb9b95b@proxmox.com> (raw)
In-Reply-To: <20210222101626.19240-1-a.lauterer@proxmox.com>
On 22.02.21 11:16, Aaron Lauterer wrote:
> Changing the width definitions to use flex will make better use on
> larger monitors. Changing the `width` parameter to `minWidth` ensures
> that on smaller screens it is still usable, though some horizontal
> scrolling might be necessary.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> www/manager6/grid/FirewallRules.js | 38 ++++++++++++++++++++----------
> 1 file changed, 25 insertions(+), 13 deletions(-)
>
>
applied, thanks! Followed up with some further changes as I remembered a discussion
I had with Dietmar about to many flex in columns (see commit message for details)
prev parent reply other threads:[~2021-02-22 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 10:16 [pve-devel] " Aaron Lauterer
2021-02-22 10:16 ` [pve-devel] [PATCH manager 2/2] ui: FirewallRules: Add tooltip to comments Aaron Lauterer
2021-02-22 13:41 ` [pve-devel] applied: " Thomas Lamprecht
2021-02-22 13:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06c826b2-3524-86ed-a4cd-c8bcfbb9b95b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.