From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] qmeventd: explicitly close() pidfds
Date: Thu, 11 Feb 2021 17:17:27 +0100 [thread overview]
Message-ID: <06bf6db0-1eea-1e6d-cd3f-29bc1325f7f6@proxmox.com> (raw)
In-Reply-To: <20210209152407.5871-1-s.reiter@proxmox.com>
On 09.02.21 16:24, Stefan Reiter wrote:
> In most circumstances a pidfd gets closed automatically once the child
> dies, and that *should* be guaranteed by us calling SIGKILL - however,
> it seems that sometimes that doesn't happen, leading to leaked file
> descriptors[0].
>
> Also add a small note to verbose mode showing when the late-cleanup
> actually happens, helped during debug.
>
> [0] https://forum.proxmox.com/threads/cannot-shutdown-vm.83911/
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> I'm puzzled by this, and I'm not entirely sure this is the full fix, but it does
> seem like a good idea to close the fds explicitly anyway.
>
> qmeventd/qmeventd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2021-02-11 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 15:24 [pve-devel] " Stefan Reiter
2021-02-11 16:17 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06bf6db0-1eea-1e6d-cd3f-29bc1325f7f6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal