Re: [pbs-devel] [RFC proxmox-backup 2/4] server: pull: factor out group pull task into helper

From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [RFC proxmox-backup 2/4] server: pull: factor out group pull task into helper
Date: Wed, 31 Jul 2024 09:38:28 +0200	[thread overview]
Message-ID: <067d1d06-8da2-4f6f-951f-b5f8a80d98e0@proxmox.com> (raw)
In-Reply-To: <20240730155600.5e2chfy626jen6hi@luna.proxmox.com>

On 7/30/24 17:56, Gabriel Goller wrote:
> On 25.07.2024 12:19, Christian Ebner wrote:
>>
>> +fn pull_group_task<'future>(
>> +    params: &'future PullParameters,
>> +    group: &'future BackupGroup,
>> +    namespace: &'future BackupNamespace,
>> +    target_namespace: &'future BackupNamespace,
>> +    progress: StoreProgress,
>> +) -> Pin<Box<dyn Future<Output = Result<(StoreProgress, PullStats, 
>> bool), Error>> + Send + 'future>>
> 
> This should be the same as making the function async:
> 
> async fn pull_group_task(...) -> Result<(...), Error> {}
> 
> 
> Just posted these two things on the mailing list so that I don't forget
> it, will follow up with a more detailed review. Will also have a look at
> how we can improve the logging as it's quite janky atm :).

Yes, thanks for the suggestion, makes above declaration much more 
readable and concise.

Also, thanks a lot for the second pair of eyes on the logging, very much 
appreciated!

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel