From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Philipp Hufnagl <p.hufnagl@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4971: client: Improve output on successful snapshot deletion
Date: Fri, 13 Oct 2023 18:29:57 +0200 [thread overview]
Message-ID: <065d595d-0b3c-4c64-a675-6f951b7775ec@proxmox.com> (raw)
In-Reply-To: <24b3bcb3-0705-46a5-975e-7f9596715e4d@proxmox.com>
Am 13/10/2023 um 16:57 schrieb Philipp Hufnagl:
> On 10/13/23 13:30, Thomas Lamprecht wrote:
>> but I'm not sure if we actually want to print anything here, did you
>> check what the other "action" (i.e., non-GET ones) do, If they all,
>> or at least most of them, print such reports too it can be fine, but
>> otherwise this would add inconsistency and simply doing nothing (i.e.,
>> exiting with SUCCESS) would be enough.
>>
> You are right! For example 'proxmox-backup-client snapshot notes
> update' does not produce any output. Ill make a v 2 on Monday removing
> the output!
>
FWIW, I do not have anything about outputting such things, especially
if other devs/users thinks that's fine, or even desired too.
But, if we do more such things then a -q/--quiet flag could be nice, e.g.,
to avoid stray output in scripts using those commands.
That said, we can always add such output later after you fixed the weird
Result { null } print, let's keep the scope small for now.
next prev parent reply other threads:[~2023-10-13 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 14:07 Philipp Hufnagl
2023-10-12 13:07 ` Dominik Csapak
2023-10-13 11:30 ` Thomas Lamprecht
2023-10-13 14:57 ` Philipp Hufnagl
2023-10-13 16:29 ` Thomas Lamprecht [this message]
2023-10-16 10:48 ` Philipp Hufnagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=065d595d-0b3c-4c64-a675-6f951b7775ec@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.