all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] traffic-control: add debug log when we found a matching rule
Date: Fri, 4 Feb 2022 11:09:23 +0100	[thread overview]
Message-ID: <06030899-49e4-7ad0-ea70-8c2bf2dd2dd7@proxmox.com> (raw)
In-Reply-To: <c34959fc-b499-4452-45c1-f3f5982cbf5d@proxmox.com>

On 2/4/22 11:05, Thomas Lamprecht wrote:
> On 04.02.22 10:12, Dominik Csapak wrote:
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> optional, at least one user in the forum has a problem with traffic
>> control, this could help debug that in the future...
> 
> Above needs to be in the commit message and actually linking to the relevant
> forum thread.
> 
> in general sure, but I dislike the direction of the approach, as its again
> moving in the same direction as e.g., pmxcfs, a single boolean flag for all
> or nothing, which in practice will soon mean that's rather useless as its
> spamming so much stuff that relevant things get drowned even for experienced
> users.
> 
> More fine grained approach it both, the verbosity and the topic axis would
> be much nicer, especially the latter as then a user could only enable
> traffic-control related logs.
> 
> But just mentioning as this is a major pain point in pmxcfs that I get "hurt"
> by frequently..

makes total sense. did you already imagine any way to enable this?
could we simply have some 'sections' (like tc,connections,etc.)
and enable them like this:

PROXMOX_DEBUG=tc=debug,conn=info,foo=none

or should we avoid the environment variable at all, and put it in
the node config?

> 
>>   src/cached_traffic_control.rs | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/cached_traffic_control.rs b/src/cached_traffic_control.rs
>> index 2f077d36..cd13bc1b 100644
>> --- a/src/cached_traffic_control.rs
>> +++ b/src/cached_traffic_control.rs
>> @@ -342,6 +342,7 @@ impl TrafficControlCache {
>>               Some((rule, _)) => {
>>                   match self.limiter_map.get(&rule.config.name) {
>>                       Some((read_limiter, write_limiter)) => {
>> +                        log::debug!("found traffic control rule for {:?} : {}", peer_ip, &rule.config.name);
>>                           (&rule.config.name, read_limiter.clone(), write_limiter.clone())
>>                       }
>>                       None => ("", None, None), // should never happen
> 





  reply	other threads:[~2022-02-04 10:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04  9:12 [pbs-devel] [PATCH proxmox-backup 1/2] use PROXMOX_DEBUG env variable to control loglevel Dominik Csapak
2022-02-04  9:12 ` [pbs-devel] [PATCH proxmox-backup 2/2] traffic-control: add debug log when we found a matching rule Dominik Csapak
2022-02-04 10:05   ` Thomas Lamprecht
2022-02-04 10:09     ` Dominik Csapak [this message]
2022-02-04 10:21       ` Thomas Lamprecht
2022-02-04 10:22 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] use PROXMOX_DEBUG env variable to control loglevel Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06030899-49e4-7ad0-ea70-8c2bf2dd2dd7@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal