Re: [pve-devel] [PATCH ha-manager 4/9] manager: remove redundant add_service_usage_to_node from next_state_started

[Fiona Ebner <f.ebner@proxmox.com>]

Am 30.09.25 um 4:20 PM schrieb Daniel Kral:
> Since 5c2eef4b ("account service to source and target during move") a
> moving HA resource's load is accounted for on the source and target
> nodes.
> 
> A HA resource in the 'started' state, which is not configured otherwise
> or has no pending CRM commands left to process, actively checks whether
> there is "better" node placement by querying select_service_node(...).
> When a better node is found, the HA resource will be migrated or
> relocated to the found node depending on their type.
> 
> The add_service_usage_to_node(...) is redundant at this point as the
> subsequent call to change_service_state(...) to either the 'migrate' or
> 'relocate' state will call recompute_online_node_usage(...) and make
> the changes to $online_node_usage be discarded immediately.

Same here, if this is still covered by change_service_state() with more
granular operations at the end of the series please mention that here
and consider it:

> Signed-off-by: Daniel Kral <d.kral@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
>  src/PVE/HA/Manager.pm | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
> index 6afc9250..468e41eb 100644
> --- a/src/PVE/HA/Manager.pm
> +++ b/src/PVE/HA/Manager.pm
> @@ -1194,9 +1194,6 @@ sub next_state_started {
>              );
>  
>              if ($node && ($sd->{node} ne $node)) {
> -                $self->{online_node_usage}->add_service_usage_to_node($node, $sid, $sd->{node});
> -                $self->{online_node_usage}->add_service_node($sid, $node);
> -
>                  if (defined(my $fallback = $sd->{maintenance_node})) {
>                      if ($node eq $fallback) {
>                          $haenv->log(



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel