From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] run env: do not store emtpy hostname
Date: Fri, 17 Nov 2023 06:37:08 +0100 [thread overview]
Message-ID: <047d4783-d5e2-48fd-8b63-8bf25a6a7383@proxmox.com> (raw)
In-Reply-To: <20231116195947.1538515-1-s.ivanov@proxmox.com>
Am 16/11/2023 um 20:59 schrieb Stoiko Ivanov:
> without this patch the hostname ends up as the empty string in
> run-env-info.json, which results in a parse-error in the TUI code
> (an empty string is not None, but still too short as hostname)
>
> Minimally tested on a VM.
>
> Fixes: bda1cdf699a3fcfc1cf3cfa446b1493689fc8eb8
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> Proxmox/Install/RunEnv.pm | 4 +++-
> Proxmox/Sys/Net.pm | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>
applied, with some code/naming (style) clean up done in a follow-up, thanks!
E.g., the method is now named get_dhcp_fqdn, as it doesn't parses out the
first part (sometimes also just named hostname) anymore, but rather passes
along the full FQDN, be it just the local part or a full host.domain one.
@christoph: please give this another sanity check.
next prev parent reply other threads:[~2023-11-17 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 19:59 [pve-devel] " Stoiko Ivanov
2023-11-17 5:37 ` Thomas Lamprecht [this message]
2023-11-17 10:11 ` [pve-devel] applied: " Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=047d4783-d5e2-48fd-8b63-8bf25a6a7383@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.