all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [RFC proxmox-backup 0/3] Encode creation parameters into pxar archive
@ 2024-03-06 14:34 Gabriel Goller
  2024-03-06 14:34 ` [pbs-devel] [PATCH proxmox-backup 1/3] pxar: factor out encode_file Gabriel Goller
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Gabriel Goller @ 2024-03-06 14:34 UTC (permalink / raw)
  To: pbs-devel

To better debug the creation of the pxar archive, we encode the 
creation_params (the parameters passed to the cli) inside the pxar
archive. Like this we just need to locate the `.pxar_creation_params`
file in the archive and we can check which arguments have been used. 

To realize this, we unify all the parameters of the `create_backup`
function so that we don't need an additional struct (which in turn
introduces additional maintenance efforts).

An example `.pxar_creation_params` file would look like this:

    {
      "backupspec": [
        "test.pxar:linux"
      ],
      "chunk-size": 4096,
      "exclude": [
        "MAINTAINERS"
      ],
      "skip-e2big-xattr": true
    }


Some background: 
The original idea came from Dietmar and while it is surely useful, I
don't really like my implementation (most likely this is a skill-issue
from my side). So suggestions/critique of any kind is welcome!  

proxmox-backup:

Gabriel Goller (3):
  pxar: factor out encode_file
  client: unify parameters and write to file
  pxar: added creation parameters

 pbs-client/src/pxar/create.rs                 | 23 ++++++-
 pbs-client/src/pxar_backup_stream.rs          |  5 +-
 proxmox-backup-client/src/main.rs             | 29 +++++---
 .../src/proxmox_restore_daemon/api.rs         |  2 +-
 pxar-bin/Cargo.toml                           |  1 +
 pxar-bin/src/main.rs                          | 67 ++++++++++++-------
 tests/catar.rs                                |  1 +
 7 files changed, 89 insertions(+), 39 deletions(-)


Summary over all repositories:
  7 files changed, 89 insertions(+), 39 deletions(-)

-- 
Generated by git-murpp 0.5.0




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-03-07  9:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06 14:34 [pbs-devel] [RFC proxmox-backup 0/3] Encode creation parameters into pxar archive Gabriel Goller
2024-03-06 14:34 ` [pbs-devel] [PATCH proxmox-backup 1/3] pxar: factor out encode_file Gabriel Goller
2024-03-06 14:34 ` [pbs-devel] [PATCH proxmox-backup 2/3] client: unify parameters and write to file Gabriel Goller
2024-03-06 14:34 ` [pbs-devel] [PATCH proxmox-backup 3/3] pxar: added creation parameters Gabriel Goller
2024-03-06 15:13 ` [pbs-devel] [RFC proxmox-backup 0/3] Encode creation parameters into pxar archive Christian Ebner
2024-03-07  9:22   ` Gabriel Goller
2024-03-07  9:50   ` Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal