From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer v2] fetch-answer: encode unsafe characters in partition label
Date: Tue, 19 Nov 2024 18:47:46 +0100 [thread overview]
Message-ID: <03daee04-cd33-454f-9b73-81272236200b@proxmox.com> (raw)
In-Reply-To: <20241119155609.118940-1-f.schauer@proxmox.com>
Am 19.11.24 um 16:56 schrieb Filip Schauer:
> Ensure potentially unsafe characters in the partition label are encoded,
> preventing the installer from failing to find the answer partition when
> the label contains whitespaces or !"$%&'()*,/;<>?[\]^`{|}~
>
> The encoding is done according to `blkid_encode_string` [0] in the blkid
> util, which is used by `/lib/udev/rules.d/60-persistent-storage.rules`
> to create a symlink under `/dev/disk/by-label/`.
>
> For example: "ANSWER PART" is encoded to "ANSWER\x20PART"
>
> [0] https://github.com/util-linux/util-linux/blob/master/libblkid/src/encode.c
>
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> Tested-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Changed since v1:
> * Log the non-encoded label instead of the encoded one when a partition
> is found.
>
> .../src/fetch_plugins/partition.rs | 22 ++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-19 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 15:56 [pve-devel] " Filip Schauer
2024-11-19 17:47 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03daee04-cd33-454f-9b73-81272236200b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.