Re: [pve-devel] [PATCH] Update cpu.weight default to match documented default

[Fiona Ebner <f.ebner@proxmox.com>]

Am 24.08.22 um 01:56 schrieb Matt Corallo:
> 
> 
> On 8/19/22 6:08 AM, Fiona Ebner wrote:
>> Hi,
>>
>> On 16.08.22 05:49, Matt Corallo wrote:
>>> Proxmox documentation describes the default CPU weight as 1024 in
>>> numerous places. However, when unset, the Linux default CGROUP
>>> weight is 100.
>>>
>>
>> I'd rather update the documentation in all places, because most likely
>> it just wasn't adapted to mention the cgroup2 default yet. Some places
>> already do mention both defaults, e.g. 'man 5 qm.conf'
> 
> Hmm, am I understanding that correctly that now I have to figure out if
> I'm using cgroup2 or cgroup1 to figure out if the default is 1024 or
> 100? Or are modern PVE's all running cgroup2 and the UI simply needs to
> be updated universally to say that the default is now 100?
> 
> Matt
> 

PVE 7.x uses cgroupv2 by default, so reporting the new default in the UI
would be correct for most installations. That said, we do still support
cgroupv1[0], so ideally, the default in the UI would be shown depending
on the cgroup version the node is actually running.

I think this was the plan, but it never got realized. This (not yet
applied) patch[1] would expose the cluster node's cgroup version to
other nodes, to be used by the frontend.

@Thomas: Is this still the plan? If it is, I'll cook up a v2 adding UI
and doc patches.

[0] https://pve.proxmox.com/wiki/Upgrade_from_6.x_to_7.0#CGroupV2
[1] https://lists.proxmox.com/pipermail/pve-devel/2021-July/049253.html