From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu] fix #4710: vma create: don't use O_DIRECT for tmpfs
Date: Tue, 7 Nov 2023 15:26:59 +0100 [thread overview]
Message-ID: <033f82ca-d1e5-47cd-9dc9-9630ca59cad4@proxmox.com> (raw)
In-Reply-To: <ac0836bd-7736-4b64-af44-fe5037b4e703@proxmox.com>
Am 07.11.23 um 15:23 schrieb Fiona Ebner:
> Am 12.09.23 um 13:55 schrieb Fiona Ebner:
>> The implementation of the helper is_path_tmpfs() is similar to the
>> existing (in upstream) qemu_fd_getfs() function in util/mmap-alloc.c,
>> which unfortunately only takes an existing fd.
>>
>
> Ping. Even though it came before the 8.1 rebase, it still applies
> cleanly on top of current master :) (because it only touches vma stuff)
Sorry, for the noise. It does not. I missed staged changes when
comparing v2 of the patch to v1 (I have a repository for comparing my
patches, it's handy :))
prev parent reply other threads:[~2023-11-07 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 11:55 Fiona Ebner
2023-11-07 14:23 ` Fiona Ebner
2023-11-07 14:26 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=033f82ca-d1e5-47cd-9dc9-9630ca59cad4@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.