From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 storage 07/10] iscsi direct plugin: support volume export
Date: Wed, 18 Dec 2024 15:07:56 +0100 [thread overview]
Message-ID: <032103c3-7ed4-437a-b1d2-96e96018dc8b@proxmox.com> (raw)
In-Reply-To: <20241217154814.82121-8-f.ebner@proxmox.com>
To test exporting a volume from the `iscsidirect` storage backend, I
installed `libiscsi-bin` and configured the storage in
`/etc/pve/storage.cfg` by using the same options as I used for the
`iscsi` storage.
```
$ pvesm export tgtdirectstorage:lun1 raw+size output
```
Then I imported the volume into a directory storage:
```
$ pvesm import local:117/vm-117-disk-0.raw raw+size output
Formatting '/var/lib/vz/images/117/vm-117-disk-0.raw', fmt=raw
size=4290772992 preallocation=off
65472+0 records in
65472+0 records out
4290772992 bytes (4.3 GB, 4.0 GiB) copied, 3.62069 s, 1.2 GB/s
successfully imported 'local:117/vm-117-disk-0.raw'
```
Assigned the disk to a VM and it also booted up just fine.
Trying to import into a user mode iSCSI storage fails as expected:
```
$ pvesm import tgtdirectstorage raw+size output
cannot import into volume 'tgtdirectstorage'
```
Tested-by: Filip Schauer <f.schauer@proxmox.com>
On 17/12/2024 16:48, Fiona Ebner wrote:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> New in v2.
>
> src/PVE/Storage/ISCSIDirectPlugin.pm | 63 ++++++++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/src/PVE/Storage/ISCSIDirectPlugin.pm b/src/PVE/Storage/ISCSIDirectPlugin.pm
> index 6f02eee..e5f6808 100644
> --- a/src/PVE/Storage/ISCSIDirectPlugin.pm
> +++ b/src/PVE/Storage/ISCSIDirectPlugin.pm
> @@ -2,9 +2,12 @@ package PVE::Storage::ISCSIDirectPlugin;
>
> use strict;
> use warnings;
> +
> use IO::File;
> +use JSON qw(decode_json);
> use HTTP::Request;
> use LWP::UserAgent;
> +
> use PVE::Tools qw(run_command file_read_firstline trim dir_glob_regex dir_glob_foreach);
> use PVE::Storage::Plugin;
> use PVE::JSONSchema qw(get_standard_option);
> @@ -252,4 +255,64 @@ sub volume_has_feature {
> return undef;
> }
>
> +sub volume_export_formats {
> + my ($class, $scfg, $storeid, $volname, $snapshot, $base_snapshot, $with_snapshots) = @_;
> +
> + return () if defined($snapshot); # not supported
> + return () if defined($base_snapshot); # not supported
> + return () if $with_snapshots; # not supported
> + return ('raw+size');
> +}
> +
> +sub volume_export {
> + my (
> + $class,
> + $scfg,
> + $storeid,
> + $fh,
> + $volname,
> + $format,
> + $snapshot,
> + $base_snapshot,
> + $with_snapshots,
> + ) = @_;
> +
> + die "volume export format $format not available for $class\n" if $format ne 'raw+size';
> + die "cannot export volumes together with their snapshots in $class\n" if $with_snapshots;
> + die "cannot export an incremental stream in $class\n" if defined($base_snapshot);
> + die "cannot export a snapshot in $class\n" if defined($snapshot);
> +
> + my $file = $class->path($scfg, $volname, $storeid, $snapshot);
> +
> + my $json = '';
> + run_command(
> + ['/usr/bin/qemu-img', 'info', '-f', 'raw', '--output=json', $file],
> + outfunc => sub { $json .= shift },
> + );
> + die "failed to query size information for '$file' with qemu-img\n" if !$json;
> + my $info = eval { decode_json($json) };
> + die "could not parse qemu-img info command output for '$file' - $@\n" if $@;
> +
> + my ($size) = ($info->{'virtual-size'} =~ /^(\d+)$/); # untaint
> + die "size '$size' not an integer\n" if !defined($size);
> + $size = int($size); # coerce back from string
> +
> + PVE::Storage::Plugin::write_common_header($fh, $size);
> + run_command(
> + ['qemu-img', 'dd', 'bs=64k', "if=$file", '-f', 'raw', '-O', 'raw'],
> + output => '>&'.fileno($fh),
> + );
> + return;
> +}
> +
> +sub volume_import_formats {
> + my ($class, $scfg, $storeid, $volname, $snapshot, $base_snapshot, $with_snapshots) = @_;
> +
> + return ();
> +}
> +
> +sub volume_import {
> + die "volume import is not possible on iscsi storage\n";
> +}
> +
> 1;
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-18 14:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 15:48 [pve-devel] [PATCH v2 storage 00/10] import/export for shared storages Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 01/10] iscsi direct plugin: fix return value for path() method in non-array context Fiona Ebner
2024-12-18 13:39 ` Fiona Ebner
2024-12-18 13:43 ` Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 02/10] rbd plugin: schema: document default value for 'krbd' setting Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 03/10] export: redirect stdout to avoid any unrelated messages ending up in the export stream Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 04/10] rbd plugin: factor out helper to check if volume already exists Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 05/10] rbd plugin: implement volume import/export Fiona Ebner
2024-12-18 14:20 ` Daniel Kral
2024-12-18 15:14 ` Fiona Ebner
2024-12-18 15:33 ` DERUMIER, Alexandre via pve-devel
2024-12-19 8:56 ` Fiona Ebner
2024-12-19 10:43 ` DERUMIER, Alexandre via pve-devel
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 06/10] iscsi plugin: support volume export Fiona Ebner
2024-12-18 14:05 ` Filip Schauer
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 07/10] iscsi direct " Fiona Ebner
2024-12-18 14:07 ` Filip Schauer [this message]
2024-12-17 15:48 ` [pve-devel] [RFC v2 storage 08/10] rbd plugin: volume exists helper: distinguish between different errors Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 09/10] common: introduce common module Fiona Ebner
2024-12-18 9:36 ` Max Carrara
2024-12-18 9:41 ` Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 10/10] plugins: volume import: align size up to 1KiB Fiona Ebner
2024-12-18 10:34 ` [pve-devel] [PATCH v2 storage 00/10] import/export for shared storages Fiona Ebner
2024-12-18 14:08 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=032103c3-7ed4-437a-b1d2-96e96018dc8b@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal