Re: [pbs-devel] [PATCH v4 proxmox-backup 09/11] datastore: use u64 instead of usize for fidx writer content size

From: Christian Ebner <c.ebner@proxmox.com>
To: Robert Obkircher <r.obkircher@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH v4 proxmox-backup 09/11] datastore: use u64 instead of usize for fidx writer content size
Date: Mon, 26 Jan 2026 15:02:48 +0100	[thread overview]
Message-ID: <02bfc738-fb21-4d14-a982-67cb42b5690e@proxmox.com> (raw)
In-Reply-To: <5aea0de2-2cc1-4c30-a609-2cdb1a2497a6@proxmox.com>

On 1/26/26 2:19 PM, Robert Obkircher wrote:
> 
> On 1/26/26 12:38, Christian Ebner wrote:
>> Not sure about these changes, maybe other devs have a stronger
>> opinion on this one.
>>
>> If we do want to adapt this, then IMHO this should however be done
>> throughout the whole codebase, for the dynamic index as well.
> The dynamic reader/writer and the FixedIndexReader already use u64 for
> content
> size and offsets. The API only supports 4 MiB chunks anyway, so it
> shouldn't matter
> if we keep using u32 there.

Disregard that comment with respect to the dynamic index in that case, 
seems indeed to be the case and I got sidetracked by the index positions 
which are usize.

But still this would be nice to have consistent, e.g. there is the check 
for chunk size used on the client side [0].

[0] 
https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=pbs-datastore/src/chunk_store.rs;h=bd1dc353b5e8f5f0e7b8f2d6788f4d29433e2a9e;hb=HEAD#l42

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel