Re: [pve-devel] applied: [PATCH qemu-server] live-restore: preload efidisk before starting VM

[Stefan Reiter <s.reiter@proxmox.com>]

On 7/1/21 12:57 PM, Thomas Lamprecht wrote:
> On 01.07.21 11:37, Stefan Reiter wrote:
>> The efidisk never got restored correctly before, since we don't use the
>> generic print_drive_commandline_full for it, and as such it didn't get a
>> backing image attached. This not only causes the efidisk data to be lost
>> on restore, but also an error at the end, since we try to remove a
>> non-existing PBS blockdev.
>>
>> Since it is attached differently to a regular drive, adding PBS backing
>> would be more difficult, but not to worry: an efidisk is small enough
>> that it doesn't hurt performance to just restore it via the regular
>> mechanism before starting the VM, and simply excluding it from the live
>> restore entirely.
>>
>> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
>> ---
>>
>> best viewed with -w
>>
>> I guess in QEMU < 6.0 this didn't cause an error, since I definitely tested with
>> EFI VMs before, however, it would have never actually restored the data and
>> instead always created a new one.
> 
> could still be good to backport, I'd figure?
> 

certainly, this should apply cleanly to 6 too I reckon?

>>
>>   PVE/QemuServer.pm | 46 ++++++++++++++++++++++++----------------------
>>   1 file changed, 24 insertions(+), 22 deletions(-)
>>
>>
> 
> applied, thanks!
>