From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5622: backup client: properly handle rate/burst parameters
Date: Thu, 1 Aug 2024 15:14:43 +0200 [thread overview]
Message-ID: <01c52f25-a04d-4dbb-b651-ac7085964b1b@proxmox.com> (raw)
In-Reply-To: <e331df36-3532-4360-8f58-f0438f4a8d73@proxmox.com>
On 8/1/24 14:44, Christian Ebner wrote:
> On 7/23/24 12:04, Dominik Csapak wrote:
>> the rate and burst parameters are integers, so the mapping from value
>> with `.as_str()` will always return `None` effectively never
>> applying any rate limit at all.
>>
>> To fix it, just map from u64 to HumanByte.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>
> Did some tests on this and while the rate limit gets applied, the burst
> value does not seem to be honored for my case. Am I misinterpreting the
> burst parameter or is there still an underlying issue?
>
> Here is what was tested:
> - Monitor network throughput to localhost by running `tcpsubnet-bpfcc
> 127.0.0.1/32` as well as `iftop` (got only low additional traffic noise
> without invoking the proxmox-backup-client).
> - Before each proxmox-backup-client invocation, the chunks and snapshots
> were deleted from the datastore to have similar conditions.
> - Backup using proxmox-backup-client to local datastore via localhost by
> running `proxmox-backup-client backup usr.pxar:/usr --rate=100000`, rate
> limit is now honored as expected!
> - `proxmox-backup-client backup usr.pxar:/usr --rate=100000
> --burst=1000000000000`, expected to reach much higher initial burst
> throughput because of the huge bucket size, but rate is limited to the
> same rate as above already from the beginning.
> - Without rate limit, much higher rates can be reached, so that is not
> the limiting factor.
Ah, I see the bucket starts empty, so this is expected then.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-08-01 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 10:04 Dominik Csapak
2024-07-23 12:48 ` Christian Ebner
2024-07-23 12:51 ` Christian Ebner
2024-08-01 12:44 ` Christian Ebner
2024-08-01 13:14 ` Christian Ebner [this message]
2024-08-07 19:20 ` Thomas Lamprecht
2024-08-08 6:51 ` Dominik Csapak
2024-08-09 8:22 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01c52f25-a04d-4dbb-b651-ac7085964b1b@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.