From: Nicholas Sherlock <nick@nicksherlock.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH v2 pve-manager] ui: pci passthrough: editor for pci-id overrides
Date: Fri, 28 Jan 2022 09:38:34 +0000 [thread overview]
Message-ID: <0100017ea00d01c7-90702c1f-c34d-4f41-b508-0c2ce396e8b5-000000@email.amazonses.com> (raw)
In-Reply-To: <0100017e9be9fa51-bfe8d998-0793-4d1a-8403-26d7b78478ac-000000@email.amazonses.com>
Sure, I'll send one along shortly.
Cheers,
Nick
On Fri, 28 Jan 2022 at 03:21, Thomas Lamprecht <nick@nicksherlock.com>
wrote:
> On 18.01.22 22:38, Nicholas Sherlock wrote:
> > From: Nicholas Sherlock <n.sherlock@gmail.com>
> >
> > Signed-off-by: Nicholas Sherlock <n.sherlock@gmail.com>
> > ---
> > www/manager6/Toolkit.js | 2 ++
> > www/manager6/qemu/PCIEdit.js | 36 ++++++++++++++++++++++++++++++++++++
> > 2 files changed, 38 insertions(+)
> >
> >
>
> applied, thanks!
>
> I adapted the labels in a follow up, but also tried to clarify where the
> value comes from if empty with a "From Device" empty-text.
>
> Further clarifications would be probably good to have in the documentation,
> would you be willing to write some short paragraph for the respective
> section
> in pve-doc's qm-pci-passthrough.adoc? No pressure though, Dominik offered
> to
> check that out too if you don't get around or the like.
>
> cheers,
> Thomas
>
>
prev parent reply other threads:[~2022-01-28 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <pci-id-override2@nicksherlock.com>
2022-01-18 21:38 ` [pve-devel] [PATCH v2 qemu-server 0/1] pci: allow override of PCI vendor/device ids Nicholas Sherlock
2022-01-20 15:48 ` Dominik Csapak
2022-01-20 21:21 ` Nicholas Sherlock
2022-01-18 21:38 ` [pve-devel] [PATCH v2 qemu-server] " Nicholas Sherlock
2022-01-25 10:02 ` [pve-devel] applied: " Thomas Lamprecht
2022-01-18 21:38 ` [pve-devel] [PATCH v2 pve-manager] ui: pci passthrough: editor for pci-id overrides Nicholas Sherlock
2022-01-27 14:21 ` [pve-devel] applied: " Thomas Lamprecht
[not found] ` <0100017e9be9fa51-bfe8d998-0793-4d1a-8403-26d7b78478ac-000000@email.amazonses.com>
2022-01-28 9:38 ` Nicholas Sherlock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0100017ea00d01c7-90702c1f-c34d-4f41-b508-0c2ce396e8b5-000000@email.amazonses.com \
--to=nick@nicksherlock.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.