From: Nicholas Sherlock <nick@nicksherlock.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 qemu-server 0/1] pci: allow override of PCI vendor/device ids
Date: Thu, 20 Jan 2022 21:21:25 +0000 [thread overview]
Message-ID: <0100017e795d9dc6-a172843a-b130-43c8-8bb6-8f1a5f9eeb54-000000@email.amazonses.com> (raw)
In-Reply-To: <d615a37b-5398-fc89-4b9e-3400ab6b5836@proxmox.com>
On Fri, 21 Jan 2022, 4:48 am Dominik Csapak, <d.csapak@proxmox.com> wrote:
> 2 nits left (you could send a v3, or we can fix it up, please
> write what you prefer)
>
> * the commit message should not have lines longer than 70 characters[0]
> * and the gettext is not optimal, i'd omit the 'Set ' prefix (sorry i did
> not
> catch it the first time), so 'Vendor ID' instead of 'Set vendor ID'
>
I would recommend keeping the "set" text in, because otherwise it makes it
look like you can pick which host device you want to pass through by using
those fields. I think it could confuse people.
Happy for you to fix the patch as needed
Cheers,
Nick
> otherwise:
>
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
>
> 0:
> https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
next prev parent reply other threads:[~2022-01-20 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <pci-id-override2@nicksherlock.com>
2022-01-18 21:38 ` Nicholas Sherlock
2022-01-20 15:48 ` Dominik Csapak
2022-01-20 21:21 ` Nicholas Sherlock [this message]
2022-01-18 21:38 ` [pve-devel] [PATCH v2 qemu-server] " Nicholas Sherlock
2022-01-25 10:02 ` [pve-devel] applied: " Thomas Lamprecht
2022-01-18 21:38 ` [pve-devel] [PATCH v2 pve-manager] ui: pci passthrough: editor for pci-id overrides Nicholas Sherlock
2022-01-27 14:21 ` [pve-devel] applied: " Thomas Lamprecht
[not found] ` <0100017e9be9fa51-bfe8d998-0793-4d1a-8403-26d7b78478ac-000000@email.amazonses.com>
2022-01-28 9:38 ` Nicholas Sherlock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0100017e795d9dc6-a172843a-b130-43c8-8bb6-8f1a5f9eeb54-000000@email.amazonses.com \
--to=nick@nicksherlock.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.