all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH-SERIES proxmox-backup] add apt repositories support
Date: Fri, 9 Jul 2021 14:00:20 +0200	[thread overview]
Message-ID: <00e7897c-0be2-35af-5017-d550012cf9cc@proxmox.com> (raw)
In-Reply-To: <20210708141429.190218-1-f.ebner@proxmox.com>

On 08.07.21 16:14, Fabian Ebner wrote:
> Basically copy-pasting the code in pve-rs and replacing instances of
> "pve" with "pbs", but there are a few minor differences, need to use
> String instead of &str, digest checking uses the local helper, can
> use APTRepositoryHandle type directly in the API.
> 
> Can also be seen as the continuation of [0], but that series already
> got it's next version, and quite a lot changed with what the UI
> expects from the API calls and also a bit with the library interface,
> so I just sent it as a new series.
> 
> [0]: https://lists.proxmox.com/pipermail/pbs-devel/2021-April/002596.html
> 
> Fabian Ebner (4):
>   depend on proxmox-apt
>   api: apt: add repositories call
>   api: apt: add endpoints for adding/changing repositories
>   ui: add APT repositories
> 
>  Cargo.toml                  |   1 +
>  debian/control              |   1 +
>  src/api2/node/apt.rs        | 218 +++++++++++++++++++++++++++++++++++-
>  www/ServerAdministration.js |   8 ++
>  4 files changed, 227 insertions(+), 1 deletion(-)
> 

Really nice to see so much code-reuse and so little code needed to get this in
here, great!

applied series, thanks!




      parent reply	other threads:[~2021-07-09 12:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 14:14 [pbs-devel] " Fabian Ebner
2021-07-08 14:14 ` [pbs-devel] [PATCH proxmox-backup 1/4] depend on proxmox-apt Fabian Ebner
2021-07-08 14:14 ` [pbs-devel] [PATCH proxmox-backup 2/4] api: apt: add repositories call Fabian Ebner
2021-07-08 14:14 ` [pbs-devel] [PATCH proxmox-backup 3/4] api: apt: add endpoints for adding/changing repositories Fabian Ebner
2021-07-08 14:14 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: add APT repositories Fabian Ebner
2021-07-09 12:00 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00e7897c-0be2-35af-5017-d550012cf9cc@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal