From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v2 2/2] fix: ui: guests missing in resources tab when status is `paused`
Date: Tue, 3 Jun 2025 10:02:56 +0200 [thread overview]
Message-ID: <af778fea-5721-4768-9eb8-6392ff79ecc8@proxmox.com> (raw)
In-Reply-To: <20250602133755.68431-3-s.shaji@proxmox.com>
On 6/2/25 15:37, Shan Shaji wrote:
> When the guest status is set to `paused` the guest was not showing in
> the resources tab. Also there were no option in the resources
> filter to select the `paused` status under the status section.
The first sentence confused me a bit. The resource tab seems to show the
guest for me, but displays its status as "Unknown". That is fixed by the
following patch. This patch "only" adds the filter. I think a commit
message like "resources: add filter option for paused guest status"
would be more appropriate.
>
> This commit fixes the issue by adding the `paused` status under the
> status section in the resources filter sheet.
nit: the commit message should not contain "This commit...".
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>
> changes since v1:
> * Removed all formatting changes.
> * New `paused` status option is added after refactoring the filter sheet.
>
> lib/widgets/pve_mobile_resource_filter_sheet.dart | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/lib/widgets/pve_mobile_resource_filter_sheet.dart b/lib/widgets/pve_mobile_resource_filter_sheet.dart
> index cee3a49..c09b2cf 100644
> --- a/lib/widgets/pve_mobile_resource_filter_sheet.dart
> +++ b/lib/widgets/pve_mobile_resource_filter_sheet.dart
> @@ -112,6 +112,20 @@ class PveMobileResourceFilterSheet extends StatelessWidget {
> ),
> ),
> ),
> + _ProxmoxResourceFilterListTile(
> + title: 'Paused',
> + value: state.statusFilter
> + .contains(PveResourceStatusType.paused),
> + onChanged: (v) => rBloc.events.add(
> + FilterResources(
> + statusFilter: _addOrRemove(
> + v!,
> + PveResourceStatusType.paused,
> + state.statusFilter,
> + ),
> + ),
> + ),
> + ),
Could make sense to do something like this:
_PveFilterSheetSection(
sectionTitle: 'Status',
items: [
for (var statusFilterItem in [
('Online', PveResourceStatusType.running),
('Offline', PveResourceStatusType.stopped),
('Paused', PveResourceStatusType.paused),
]) _ProxmoxResourceFilterListTile(
title: statusFilterItem.$1,
value: state.statusFilter
.contains(statusFilterItem.$2),
onChanged: (v) => rBloc.events.add(
FilterResources(
statusFilter: _addOrRemove(
v!,
statusFilterItem.$2,
state.statusFilter,
),
),
),
),
],
)
instead of copying the entire _ProxmoxResourceFilterListTile every time
we want to add another status as a filter. Not directly related to this
patch, just a suggestion. If you do send a v3 including this, it should
probably be a separate patch.
> ],
> )
> ],
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-03 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 13:37 [pve-devel] [PATCH proxmox_dart_api_client/pve_flutter_frontend v2 0/3] fix: ui: guest " Shan Shaji
2025-06-02 13:37 ` [pve-devel] [PATCH pve_flutter_frontend v2 1/2] refactor: move and split the `_MobileResourceFilterSheet` widget Shan Shaji
2025-06-03 8:10 ` Michael Köppl
2025-06-02 13:37 ` [pve-devel] [PATCH pve_flutter_frontend v2 2/2] fix: ui: guests missing in resources tab when status is `paused` Shan Shaji
2025-06-03 8:02 ` Michael Köppl [this message]
2025-06-02 13:37 ` [pve-devel] [PATCH proxmox_dart_api_client v2 1/1] fix: ui: add missing `paused` status check Shan Shaji
2025-06-03 8:15 ` [pve-devel] [PATCH proxmox_dart_api_client/pve_flutter_frontend v2 0/3] fix: ui: guest missing in resources tab when status is `paused` Michael Köppl
2025-06-05 9:46 ` Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af778fea-5721-4768-9eb8-6392ff79ecc8@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal