Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support

From: Fiona Ebner <f.ebner@proxmox.com>
To: "joao.sousa" <joao.sousa@eurotux.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support
Date: Mon, 16 Jun 2025 10:34:56 +0200	[thread overview]
Message-ID: <acc00cf2-c269-4a42-98ea-0f430449b04d@proxmox.com> (raw)
In-Reply-To: <zwkygc6va6jmieho2h7gqsx4idrgrxvd7et2kfbi3vyddhjk7c@kfiwufb7auvv>

Am 13.06.25 um 12:25 schrieb joao.sousa:
> On 12/06/25 10:12, Fiona Ebner wrote:
>> The tests in qemu-server were updated since then. You can check out an
>> earlier commit and apply on top of that. For pve-storage, I'd guess it
>> was the code style changes, so same story:
> 
> I reverted qemu-server to commit 1fd1ca60, however it still fails to
> apply patch 12:
> 
> [PATCH qemu-server 12/13] blockdev: add backing_chain support
> 
> Applying: blockdev: add backing_chain support
> error: corrupt patch at line 18
> Patch failed at 0012 blockdev: add backing_chain support
> hint: Use 'git am --show-current-patch=diff' to see the failed patch

Right, that one failed for me as well. Didn't check out why exactly, but
there will be a separate series for the switch to blockdev [0]. After
that, Alexandre can rebase the changes for external snapshot on top and
send another version of the patches.

[0]:
https://lore.proxmox.com/pve-devel/mailman.381.1750055007.395.pve-devel@lists.proxmox.com/T/

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel