From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v1] chore: update `compileSdkVersion` to 35 and `targetSdkVersion` to 36
Date: Thu, 3 Jul 2025 16:25:06 +0200 [thread overview]
Message-ID: <a4adab73-1ce4-48a3-b66e-86770523cde8@proxmox.com> (raw)
In-Reply-To: <20499aba-f114-4a55-92bd-e43eca44cab7@proxmox.com>
Am 03.07.25 um 16:03 schrieb Dominik Csapak:
> LGTM, and built + tested fine here,
> but maybe someone else also wants to take a look too... (@thomas?)
>
> Does it even make sense to set the targetSdkVersion higher than the compiled one?
Yeah, that can be fine, the targetSdkVersion basically denotes what (API)
version one tested the App against and signals Android that it doesn't need
to enable any backward compat handling as long as the Android (API) version
is equal or lower than the provided targetSdkVersion.
Such compat handling could e.g. be w.r.t. App permissions, if there are
newer more granular one, or the default set got reduced it might break older
apps, so that is only enabled if the app signals that it supports it,
naturally with some time window to not allow uploading an app (update) to
avoid that this can be misused.
The compileSdkVersion is the API the app is compiled against and thus
one can only actively use newer APIs if one increases this. Most of the time
one want's to have those two in sync, but it's fine if the targetSdkVersion
gets higher, it just cannot be lower than the compiled one.
>
> Otherwise, consider this
>
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-03 14:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 9:10 Shan Shaji
2025-07-03 14:03 ` Dominik Csapak
2025-07-03 14:20 ` Tim Marx
2025-07-03 14:28 ` Thomas Lamprecht
2025-07-03 14:25 ` Thomas Lamprecht [this message]
2025-07-03 14:45 ` Dominik Csapak
2025-07-03 14:56 ` Thomas Lamprecht
2025-07-03 15:18 ` Tim Marx
2025-07-04 6:52 ` Shan Shaji
2025-07-04 8:53 ` Thomas Lamprecht
2025-07-04 11:15 ` Shan Shaji
2025-07-07 9:51 ` Shan Shaji
2025-07-03 14:36 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4adab73-1ce4-48a3-b66e-86770523cde8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal