Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
	"DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>,
	"pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support
Date: Fri, 6 Jun 2025 10:27:46 +0200 (CEST)	[thread overview]
Message-ID: <601629105.3366.1749198466950@webmail.proxmox.com> (raw)
In-Reply-To: <6ed8b9a3-e706-42b1-84c6-d4078782c393@proxmox.com>

> Fiona Ebner <f.ebner@proxmox.com> hat am 06.06.2025 09:50 CEST geschrieben:
> 
>  
> Am 05.06.25 um 16:39 schrieb DERUMIER, Alexandre:
> > Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel:
> >> +sub encode_nodename {
> >> +    my ($type, $volid, $snap) = @_;
> >> +
> >> +    my $nodename = "$volid";
> >> +    $nodename .= "-$snap" if $snap;
> > 
> > This will lead to clashes in some cases:
> >>> 1. Currently, we allow attaching the same volume multiple times to a
> >>> single guest.
> > do you mean, manually with editing the vm configuration ?  What is the
> > usecase ? (I mean, without breaking the fs because the drive could be
> > mounted twice )
> > (the vm will not start if node-name is duplicated, so it's look more
> > secure now ^_^)
> 
> No manual editing needed, just use "qm set" twice with the same volume
> ;) Sure, those are most likely quite exotic use cases. If we want to, we
> could go ahead an prohibit this for PVE 9. There always is the -args
> escape hatch for people that really need it. Would also avoid cases
> where it's done accidentally, so I'm not opposed to this. We'd need to
> document it as a breaking change in the upgrade guide and add a check to
> the pve8to9 script.

it is very handy for testing multipath ;) we could add the "slot" to the 
input for deriving the node name?

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel