From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES qemu-server 0/3] image convert: fix handling qcow2 on snapshot-as-volume-chain dir target
Date: Wed, 30 Jul 2025 17:03:14 +0200 [thread overview]
Message-ID: <20250730150325.138087-1-f.ebner@proxmox.com> (raw)
As reported by Friedrich, having qcow2 on a snapshot-as-volume-chain
directory storage be the target would fail with:
> Block format 'qcow2' does not support the option 'zeroinit:driver'
First patch is to work around this by just not specifying zeroinit
which leads to a performance penalty.
Following patches would fix the issue by actually using the zeroinit
driver, and we meet and old friend again with 2/3 :P (patch was
proposed once before already).
Fiona Ebner (3):
image convert: avoid combining target image options and zeroinit
filter
image convert: re-use generate_drive_blockdev()
image convert: make using zeroinit with target-image-opts work
src/PVE/QemuServer/QemuImage.pm | 77 ++++++++++++++++++++++----
src/test/run_qemu_img_convert_tests.pl | 47 +++++++++++++---
2 files changed, 107 insertions(+), 17 deletions(-)
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-07-30 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 15:03 Fiona Ebner [this message]
2025-07-30 15:03 ` [pve-devel] [PATCH qemu-server 1/3] image convert: avoid combining target image options and zeroinit filter Fiona Ebner
2025-07-30 15:03 ` [pve-devel] [PATCH qemu-server 2/3] image convert: re-use generate_drive_blockdev() Fiona Ebner
2025-07-30 15:03 ` [pve-devel] [PATCH qemu-server 3/3] image convert: make using zeroinit with target-image-opts work Fiona Ebner
2025-07-30 22:23 ` [pve-devel] applied: [PATCH-SERIES qemu-server 0/3] image convert: fix handling qcow2 on snapshot-as-volume-chain dir target Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730150325.138087-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.