all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager v4 2/3] pve8to9: move checklist to dedicated subcommand
Date: Mon,  7 Jul 2025 10:03:30 +0200	[thread overview]
Message-ID: <20250707080352.58713-5-f.weber@proxmox.com> (raw)
In-Reply-To: <20250707080352.58713-1-f.weber@proxmox.com>

This allows to introduce other subcommands, e.g. for manual actions
rqeuired before the upgrade.

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---

Notes:
    changes since v3:
    - rephrase commit message
    
    new in v3

 PVE/CLI/pve8to9.pm | 4 +++-
 bin/Makefile       | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 45692748..c3fb0b0b 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1595,6 +1595,8 @@ __PACKAGE__->register_method({
     },
 });
 
-our $cmddef = [__PACKAGE__, 'checklist', [], {}];
+our $cmddef = {
+    checklist => [__PACKAGE__, 'checklist', []],
+};
 
 1;
diff --git a/bin/Makefile b/bin/Makefile
index caed0af4..23635a16 100644
--- a/bin/Makefile
+++ b/bin/Makefile
@@ -73,7 +73,7 @@ pve8to9.1:
 	 before, and during the upgrade of a Proxmox VE system\n" >> $@.tmp
 	printf "Any failure must be addressed before the upgrade, and any warning must be addressed, \
 	 or at least carefully evaluated, if a false-positive is suspected\n" >> $@.tmp
-	printf ".SH SYNOPSIS\npve8to9 [--full]\n" >> $@.tmp
+	printf ".SH SYNOPSIS\npve8to9 checklist [--full]\n" >> $@.tmp
 	mv $@.tmp $@
 
 
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-07-07  8:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07  8:03 [pve-devel] [PATCH manager/storage v4 0/5] fix #4997: lvm, lvm-thin: avoid autoactivating LVs Friedrich Weber
2025-07-07  8:03 ` [pve-devel] [PATCH pve-storage v4 1/2] fix #4997: lvm: create: disable autoactivation for new logical volumes Friedrich Weber
2025-07-07  8:03 ` [pve-devel] [PATCH pve-storage v4 2/2] lvmthin: " Friedrich Weber
2025-07-07  8:03 ` [pve-devel] [PATCH pve-manager v4 1/3] pve8to9: run perltidy Friedrich Weber
2025-07-07  8:03 ` Friedrich Weber [this message]
2025-07-07 18:46   ` [pve-devel] [PATCH pve-manager v4 2/3] pve8to9: move checklist to dedicated subcommand Thomas Lamprecht
2025-07-08 10:18     ` Friedrich Weber
2025-07-07  8:03 ` [pve-devel] [PATCH pve-manager v4 3/3] pve8to9: detect and (if requested) disable LVM autoactivation Friedrich Weber
2025-07-08  8:38 ` [pve-devel] [PATCH manager/storage v4 0/5] fix #4997: lvm, lvm-thin: avoid autoactivating LVs Thomas Lamprecht
2025-07-08 10:16   ` Friedrich Weber
2025-07-08 10:19     ` Thomas Lamprecht
2025-07-09 14:13 ` [pve-devel] superseded: " Friedrich Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250707080352.58713-5-f.weber@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal