From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [yew-devel] [PATCH yew-widget-toolkit 10/11] touch: fab menu: convert to widget macro
Date: Fri, 27 Jun 2025 14:08:58 +0200 [thread overview]
Message-ID: <20250627120859.3723554-17-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250627120859.3723554-1-d.csapak@proxmox.com>
This does many things we did here manually.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
| 57 ++++++-------------------------------------
1 file changed, 8 insertions(+), 49 deletions(-)
--git a/src/touch/fab_menu.rs b/src/touch/fab_menu.rs
index 4ad1234..92f2331 100644
--- a/src/touch/fab_menu.rs
+++ b/src/touch/fab_menu.rs
@@ -1,12 +1,10 @@
-use std::rc::Rc;
-
-use yew::html::IntoPropValue;
use yew::prelude::*;
-use yew::virtual_dom::{Key, VComp, VNode};
use crate::props::{ContainerBuilder, EventSubscriber, WidgetBuilder};
use crate::widget::Container;
+use pwt_macros::{builder, widget};
+
use super::Fab;
/// [FabMenu] direction.
@@ -27,12 +25,10 @@ pub enum FabMenuAlign {
}
/// Favorite actions button Menu.
+#[widget(pwt=crate, comp=PwtFabMenu, @element)]
#[derive(Properties, Clone, PartialEq)]
+#[builder]
pub struct FabMenu {
- /// The yew component key.
- #[prop_or_default]
- pub key: Option<Key>,
-
/// Main button Icon (CSS class).
#[prop_or_default]
pub main_icon_class: Option<Classes>,
@@ -43,11 +39,13 @@ pub struct FabMenu {
/// Menu popup direction
#[prop_or(FabMenuDirection::Up)]
+ #[builder]
pub direction: FabMenuDirection,
/// Menu alignment
///
#[prop_or(FabMenuAlign::Center)]
+ #[builder]
pub align: FabMenuAlign,
/// Child buttons, which popup when main button is pressed.
@@ -69,17 +67,6 @@ impl FabMenu {
yew::props!(Self {})
}
- /// Builder style method to set the yew `key` property
- pub fn key(mut self, key: impl IntoPropValue<Option<Key>>) -> Self {
- self.set_key(key);
- self
- }
-
- /// Method to set the yew `key` property
- pub fn set_key(&mut self, key: impl IntoPropValue<Option<Key>>) {
- self.key = key.into_prop_value();
- }
-
/// Builder style method to set the icon class for the main button.
pub fn main_icon_class(mut self, class: impl Into<Classes>) -> Self {
self.set_main_icon_class(class);
@@ -106,28 +93,6 @@ impl FabMenu {
}
}
- /// Builder style method to set the popup alignment
- pub fn align(mut self, align: FabMenuAlign) -> Self {
- self.set_align(align);
- self
- }
-
- /// Method to set the popup alignment
- pub fn set_align(&mut self, align: FabMenuAlign) {
- self.align = align;
- }
-
- /// Builder style method to set the popup direction
- pub fn direction(mut self, direction: FabMenuDirection) -> Self {
- self.set_direction(direction);
- self
- }
-
- /// Method to set the popup direction
- pub fn set_direction(&mut self, direction: FabMenuDirection) {
- self.direction = direction;
- }
-
/// Builder style method to add a child button
pub fn with_child(mut self, child: impl Into<Fab>) -> Self {
self.add_child(child);
@@ -180,6 +145,8 @@ impl Component for PwtFabMenu {
};
let mut container = Container::new()
+ .with_std_props(&props.std_props)
+ .listeners(&props.listeners)
.class("pwt-fab-menu-container")
.class(match props.align {
FabMenuAlign::Start => Some("pwt-fab-align-start"),
@@ -232,11 +199,3 @@ impl Component for PwtFabMenu {
container.into()
}
}
-
-impl From<FabMenu> for VNode {
- fn from(val: FabMenu) -> Self {
- let key = val.key.clone();
- let comp = VComp::new::<PwtFabMenu>(Rc::new(val), key);
- VNode::from(comp)
- }
-}
--
2.39.5
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
next prev parent reply other threads:[~2025-06-27 12:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 12:08 [yew-devel] [PATCH yew-widget-toolkit/yew-widget-toolkit-assets 00/17] various touch improvements Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 1/6] reset: remove the tap highlight color for chrome Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 2/6] page: add more page animation styles Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 3/6] page: animations: reverse the direction on X axis for RTL mode Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 4/6] application bar: reduce horizontal padding Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 5/6] application bar: reverse back arrow for rtl Dominik Csapak
2025-06-27 12:54 ` Shannon Sterz
2025-06-27 13:38 ` Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 6/6] buttons: rework fab menu Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 01/11] widget: implement Image widget Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 02/11] widget: button: don't hardcode icons font size Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 03/11] touch: page stack: add more animations Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 04/11] touch: application bar: set custom class on back button Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 05/11] touch: material app: allow pass through of page animation style Dominik Csapak
2025-06-27 13:37 ` Shannon Sterz
2025-06-27 13:38 ` Dominik Csapak
2025-06-27 14:32 ` Dietmar Maurer
2025-06-27 14:40 ` Shannon Sterz
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 06/11] touch: scaffold: fix overflow setting for body Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 07/11] touch: scaffold: use direction independent positioning for the FAB Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 08/11] touch: fab: add size option Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 09/11] touch: fab: convert to widget macro Dominik Csapak
2025-06-27 12:08 ` Dominik Csapak [this message]
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 11/11] touch: fab menu: rework fab menu Dominik Csapak
2025-06-30 8:25 ` [yew-devel] [PATCH yew-widget-toolkit/yew-widget-toolkit-assets 00/17] various touch improvements Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250627120859.3723554-17-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal