[pve-devel] [PATCH docs/installer v3 0/8] add early disk and network sanity checks

From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH docs/installer v3 0/8] add early disk and network sanity checks
Date: Thu, 26 Jun 2025 17:11:11 +0200	[thread overview]
Message-ID: <20250626151119.255169-1-m.koeppl@proxmox.com> (raw)

The goal of this series is to add additional sanity checks to the
auto-installer and the TUI and GUI installers. The following checks were
added:
* Btrfs / ZFS RAID: check if the required number of disks is available
* LVM: check if swapsize < hdsize
* Duplicate disks in answer file disk selection
* Networking: check if IPv4 address is valid within subnet (RFC)

Additionally, the documentation regarding maxroot is adapted to remove
the maximum maxroot size requirement since there was no check and adding
a sanity check would have prevented users from installing on setups with
very small disks even if the installation could have succeeded.

The disk-related checks aim to close [0], whereas the IPv4 check would
partially close [1].

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=5887
[1] https://bugzilla.proxmox.com/show_bug.cgi?id=5757

Changes since v2:
- Rebased on master
- Removed maxroot check and instead adapted documentation
- Remove some changes that were the result of formatting otherwise
  unchanged lines of code
- Added patch to improve error handling when checking CIDR address TUI
  network dialog
- In installer 7/7, use the limit variable for the check_mask_limit
  function instead of hardcoded 32

Changes since v1:
- Removed rustfmt patch
- Removed patch that changed check_zfs_raid_config (replaced with patch
  below)
- Added patch that moves implementation of RAID setup checks to
  implementation of ZfsRaidLevel and BtrfsRaidLevel
- Adapted tests for RAID setup validity
- Added configured values in GiB to error messages for invalid
  swapsize and maxroot
- Changed maximum allowed swapsize to hdsize/8
- De-duplicated swapsize and maxroot check implementations in
  autoinstaller utils and common's disk_checks
- Added patch that adds a check for duplicate disks in answer file disk
  selection
- Refactored Display implementation of CidrAddressParseError
- Simplified Deserialize implementation of CidrAddress
- Explicitly allow /31 and /32 subnets in CIDR validity check

Thanks to @Christoph for reviewing the previous versions and his suggestions.

pve-installer:

Michael Köppl (7):
  auto: add early answer file sanity check for RAID configurations
  move RAID setup checks to RAID level enum implementations
  close #5887: add sanity check for LVM swapsize
  auto: add check for duplicate disks in answer file
  common: add more descriptive errors for invalid network configs
  tui: change get_value return type for easier error handling
  common: add checks for valid subnet mask and IPv4 address within
    subnet

 Proxmox/Install.pm                            |   8 +
 proxinstall                                   |   4 +-
 proxmox-auto-install-assistant/src/main.rs    |   3 +-
 proxmox-auto-installer/src/utils.rs           |  40 ++++-
 proxmox-auto-installer/tests/parse-answer.rs  |   9 +-
 .../parse_answer/ipv4_and_subnet_31.json      |  19 +++
 .../parse_answer/ipv4_and_subnet_31.toml      |  18 ++
 .../btrfs_raid_single_disk.json               |   3 +
 .../btrfs_raid_single_disk.toml               |  15 ++
 .../parse_answer_fail/duplicate_disk.json     |   3 +
 .../parse_answer_fail/duplicate_disk.toml     |  15 ++
 .../ipv4_and_subnet_addr_is_network.json      |   3 +
 .../ipv4_and_subnet_addr_is_network.toml      |  18 ++
 .../ipv4_and_subnet_mask_33.json              |   3 +
 .../ipv4_and_subnet_mask_33.toml              |  18 ++
 .../lvm_swapsize_greater_than_hdsize.json     |   3 +
 .../lvm_swapsize_greater_than_hdsize.toml     |  16 ++
 .../zfs_raid_single_disk.json                 |   3 +
 .../zfs_raid_single_disk.toml                 |  15 ++
 proxmox-installer-common/src/disk_checks.rs   | 156 +++++-------------
 proxmox-installer-common/src/options.rs       |  91 ++++++++++
 proxmox-installer-common/src/utils.rs         |  85 ++++++++--
 proxmox-tui-installer/src/main.rs             |   8 +-
 proxmox-tui-installer/src/views/bootdisk.rs   |  13 +-
 proxmox-tui-installer/src/views/mod.rs        |   8 +-
 25 files changed, 435 insertions(+), 142 deletions(-)
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/ipv4_and_subnet_31.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/ipv4_and_subnet_31.toml
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/btrfs_raid_single_disk.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/btrfs_raid_single_disk.toml
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/duplicate_disk.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/duplicate_disk.toml
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/ipv4_and_subnet_addr_is_network.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/ipv4_and_subnet_addr_is_network.toml
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/ipv4_and_subnet_mask_33.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/ipv4_and_subnet_mask_33.toml
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/zfs_raid_single_disk.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/zfs_raid_single_disk.toml

pve-docs:

Michael Köppl (1):
  installation: remove maxroot size requirement and mention default
    instead

 pve-installation.adoc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Summary over all repositories:
  26 files changed, 438 insertions(+), 143 deletions(-)

-- 
Generated by git-murpp 0.8.0

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel