all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES qemu-server 00/31] preparation for blockdev, part three
Date: Wed, 25 Jun 2025 17:56:23 +0200	[thread overview]
Message-ID: <20250625155751.268047-1-f.ebner@proxmox.com> (raw)

Changes to OVMF patches (left-over from part two):
* 01/31 is new
* keep get_efivars_size() as a wrapper in QemuServer module
* keep early check for CPU bitness in QemuServer module
* use read-only flag for OVMF code
* collect some parameters into $hw_info hash, avoid querying AMD-SEV
  type inside the OVMF module

Splits out a Network module, qga_check_running(),
find_vmstate_storage(), QemuMigrate::Helpers, a RunState module with
the goal of splitting out a BlockJob module, where blockdev_mirror()
will be added.

Need some more time to make zeroinit work properly, got an initial
QEMU patch locally, but need to finalize it. Also need to check why
exactly block-export-add fails without Alexandre's patch, since we do
query the node name there. We shouldn't use the top node there in any
case, because we don't want to be limited by limits intended for the
guest during migration.

Therefore, the patches from 24/31 onwards are RFC, not finalized, just
for context and easier testing for reviewers.


Fiona Ebner (31):
  print ovmf commandline: collect hardware parameters into hash argument
  introduce OVMF module
  ovmf: add support for using blockdev
  cfg2cmd: ovmf: support print_ovmf_commandline() returning machine
    flags
  assume that SDN is available
  schema: remove unused pve-qm-ipconfig standard option
  remove unused $nic_model_list_txt variable
  introduce Network module
  agent: drop unused $noerr argument from helpers
  agent: code style: order module imports according to style guide
  agent: avoid dependency on QemuConfig module
  agent: avoid use of deprecated check_running() function
  agent: move qga_check_running() to agent module
  move find_vmstate_storage() helper to QemuConfig module
  introduce QemuMigrate::Helpers module
  introduce RunState module
  code cleanup: drive mirror: do not prefix calls to function in the
    same module
  introduce BlockJob module
  drive: die in get_drive_id() if argument misses relevant members
  block job: add and use wrapper for mirror
  drive mirror: add variable for device ID and make name for drive ID
    precise
  test: migration: factor out common mocking for mirror
  block job: factor out helper for common mirror QMP options
  block job: add blockdev mirror
  blockdev: support using zeroinit filter
  blockdev: make some functions private
  clone disk: skip check for aio=default (io_uring) compatibility
    starting with machine version 10.0
  print drive device: don't reference any drive for 'none' starting with
    machine version 10.0
  blockdev: add support for NBD paths
  command line: switch to blockdev starting with machine version 10.0
  test: migration: update running machine to 10.0

 src/PVE/API2/Qemu.pm                          |   44 +-
 src/PVE/API2/Qemu/Agent.pm                    |   28 +-
 src/PVE/CLI/qm.pm                             |   11 +-
 src/PVE/Makefile                              |    1 +
 src/PVE/QemuConfig.pm                         |   60 +-
 src/PVE/QemuMigrate.pm                        |   43 +-
 src/PVE/QemuMigrate/Helpers.pm                |  146 ++
 src/PVE/QemuMigrate/Makefile                  |    9 +
 src/PVE/QemuServer.pm                         | 1537 +++--------------
 src/PVE/QemuServer/Agent.pm                   |   57 +-
 src/PVE/QemuServer/BlockJob.pm                |  529 ++++++
 src/PVE/QemuServer/Blockdev.pm                |   40 +-
 src/PVE/QemuServer/Cloudinit.pm               |   18 +-
 src/PVE/QemuServer/Drive.pm                   |    4 +
 src/PVE/QemuServer/Makefile                   |    4 +
 src/PVE/QemuServer/Network.pm                 |  324 ++++
 src/PVE/QemuServer/OVMF.pm                    |  233 +++
 src/PVE/QemuServer/RunState.pm                |  185 ++
 src/PVE/VZDump/QemuServer.pm                  |    3 +-
 src/test/MigrationTest/QemuMigrateMock.pm     |   58 +-
 src/test/MigrationTest/QmMock.pm              |    3 -
 src/test/MigrationTest/Shared.pm              |   11 +
 src/test/cfg2cmd/aio.conf.cmd                 |   42 +-
 src/test/cfg2cmd/bootorder-empty.conf.cmd     |   13 +-
 src/test/cfg2cmd/bootorder-legacy.conf.cmd    |   13 +-
 src/test/cfg2cmd/bootorder.conf.cmd           |   13 +-
 ...putype-icelake-client-deprecation.conf.cmd |    7 +-
 src/test/cfg2cmd/efi-raw-template.conf.cmd    |    7 +-
 src/test/cfg2cmd/efi-raw.conf.cmd             |    7 +-
 .../cfg2cmd/efi-secboot-and-tpm-q35.conf.cmd  |    7 +-
 src/test/cfg2cmd/efi-secboot-and-tpm.conf.cmd |    7 +-
 src/test/cfg2cmd/efidisk-on-rbd.conf.cmd      |    7 +-
 src/test/cfg2cmd/ide.conf.cmd                 |   15 +-
 src/test/cfg2cmd/q35-ide.conf.cmd             |   15 +-
 .../q35-linux-hostpci-mapping.conf.cmd        |    7 +-
 .../q35-linux-hostpci-multifunction.conf.cmd  |    7 +-
 .../q35-linux-hostpci-template.conf.cmd       |   10 +-
 ...q35-linux-hostpci-x-pci-overrides.conf.cmd |    7 +-
 src/test/cfg2cmd/q35-linux-hostpci.conf.cmd   |    7 +-
 src/test/cfg2cmd/q35-simple.conf.cmd          |    7 +-
 src/test/cfg2cmd/seabios_serial.conf.cmd      |    7 +-
 src/test/cfg2cmd/sev-es.conf.cmd              |    7 +-
 src/test/cfg2cmd/sev-std.conf.cmd             |    7 +-
 src/test/cfg2cmd/simple-btrfs.conf.cmd        |   16 +-
 src/test/cfg2cmd/simple-cifs.conf.cmd         |   16 +-
 .../cfg2cmd/simple-disk-passthrough.conf.cmd  |    9 +-
 src/test/cfg2cmd/simple-lvm.conf.cmd          |   12 +-
 src/test/cfg2cmd/simple-lvmthin.conf.cmd      |   12 +-
 src/test/cfg2cmd/simple-rbd.conf.cmd          |   28 +-
 src/test/cfg2cmd/simple-virtio-blk.conf.cmd   |    7 +-
 .../cfg2cmd/simple-zfs-over-iscsi.conf.cmd    |   16 +-
 src/test/cfg2cmd/simple1-template.conf.cmd    |   10 +-
 src/test/cfg2cmd/simple1.conf.cmd             |    7 +-
 src/test/run_config2command_tests.pl          |   22 +
 src/test/run_qemu_migrate_tests.pl            |   16 +-
 src/test/snapshot-test.pm                     |   11 +-
 src/usr/pve-bridge                            |   24 +-
 57 files changed, 2213 insertions(+), 1560 deletions(-)
 create mode 100644 src/PVE/QemuMigrate/Helpers.pm
 create mode 100644 src/PVE/QemuMigrate/Makefile
 create mode 100644 src/PVE/QemuServer/BlockJob.pm
 create mode 100644 src/PVE/QemuServer/Network.pm
 create mode 100644 src/PVE/QemuServer/OVMF.pm
 create mode 100644 src/PVE/QemuServer/RunState.pm

-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-06-25 16:00 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25 15:56 Fiona Ebner [this message]
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 01/31] print ovmf commandline: collect hardware parameters into hash argument Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 02/31] introduce OVMF module Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 03/31] ovmf: add support for using blockdev Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 04/31] cfg2cmd: ovmf: support print_ovmf_commandline() returning machine flags Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 05/31] assume that SDN is available Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 06/31] schema: remove unused pve-qm-ipconfig standard option Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 07/31] remove unused $nic_model_list_txt variable Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 08/31] introduce Network module Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 09/31] agent: drop unused $noerr argument from helpers Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 10/31] agent: code style: order module imports according to style guide Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 11/31] agent: avoid dependency on QemuConfig module Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 12/31] agent: avoid use of deprecated check_running() function Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 13/31] agent: move qga_check_running() to agent module Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 14/31] move find_vmstate_storage() helper to QemuConfig module Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 15/31] introduce QemuMigrate::Helpers module Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 16/31] introduce RunState module Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 17/31] code cleanup: drive mirror: do not prefix calls to function in the same module Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 18/31] introduce BlockJob module Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 19/31] drive: die in get_drive_id() if argument misses relevant members Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 20/31] block job: add and use wrapper for mirror Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 21/31] drive mirror: add variable for device ID and make name for drive ID precise Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 22/31] test: migration: factor out common mocking for mirror Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 23/31] block job: factor out helper for common mirror QMP options Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [RFC qemu-server 24/31] block job: add blockdev mirror Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [RFC qemu-server 25/31] blockdev: support using zeroinit filter Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [PATCH qemu-server 26/31] blockdev: make some functions private Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [RFC qemu-server 27/31] clone disk: skip check for aio=default (io_uring) compatibility starting with machine version 10.0 Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [RFC qemu-server 28/31] print drive device: don't reference any drive for 'none' " Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [RFC qemu-server 29/31] blockdev: add support for NBD paths Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [RFC qemu-server 30/31] command line: switch to blockdev starting with machine version 10.0 Fiona Ebner
2025-06-25 15:56 ` [pve-devel] [RFC qemu-server 31/31] test: migration: update running machine to 10.0 Fiona Ebner
2025-06-26 13:09 ` [pve-devel] partially-applied: [PATCH-SERIES qemu-server 00/31] preparation for blockdev, part three Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250625155751.268047-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal