[pve-devel] [PATCH-SERIES qemu-server 00/22] preparation for switch to blockdev

From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES qemu-server 00/22] preparation for switch to blockdev
Date: Thu, 12 Jun 2025 16:02:31 +0200	[thread overview]
Message-ID: <20250612140253.106555-1-f.ebner@proxmox.com> (raw)

This is a preparatory series for the switch to -blockdev with Proxmox
VE 9, QEMU machine version 10.0, based in part on Alexandre's series
here [0].

While the last patch actually does the switch, many operations are not
yet supported. It is included to show what changes I made there. It
should not yet be applied and supporting everything is the goal for a
following series based on the rest of Alexandre's patches. It was time
to send this however, as it's already gotten large enough (but most
patches are quite small, so don't worry reviewers ;)).

There are mostly cleanups, moving and defining helpers, as well as
doing non-intrusive preparation for the switch with machine version
10.0. Quite a large chunk of the series is for having
activate_volumes() be called before config_to_command() with proper
cleanup handling.

A breaking change is the removal of the gone-since-QEMU-3.1 drive
geometry options. It was not possible to even start or backup a VM
with those options set since then. Still, restore of old backups with
such an option is made explicitly supported.

[0]: https://lore.proxmox.com/pve-devel/mailman.347.1749728041.395.pve-devel@lists.proxmox.com/T/

Fiona Ebner (22):
  drive: code cleanup: drop unused $vmid parameter from
    get_path_and_format()
  cfg2cmd: require at least QEMU binary version 6.0
  drive: parse: use hash argument for optional parameters
  drive: parse drive: support parsing with additional properties
  restore: parse drive with additional properties
  drive: remove geometry options gone since QEMU 3.1
  clone disk: io uring check: fix call to determine cache direct
  drive: move storage_allows_io_uring_default() and
    drive_uses_cache_direct() helpers to drive module
  drive: introduce aio_cmdline_option() helper
  drive: introduce detect_zeroes_cmdline_option() helper
  introduce StateFile module for state file related helpers
  vm start: move state file handling to dedicated module
  vm start: move config_to_command() call further down
  vm start/commandline: also clean up pci reservation when
    config_to_command() fails
  vm start/commandline: activate volumes before config_to_command()
  print drive device: explicitly set write-cache starting with machine
    version 10.0
  print drive device: set {r,w}error front-end properties starting with
    machine version 10.0
  print drive device: don't reference any drive for 'none' starting with
    machine version 10.0
  drive: create a throttle group for each drive starting with machine
    version 10.0
  blockdev: add helpers to generate blockdev commandline
  blockdev: add support for NBD paths
  command line: switch to blockdev starting with machine version 10.0

 PVE/API2/Qemu.pm                 |  12 +-
 PVE/QemuServer.pm                | 480 +++++++++++++++++--------------
 PVE/QemuServer/Blockdev.pm       | 229 +++++++++++++++
 PVE/QemuServer/Drive.pm          | 110 +++++--
 PVE/QemuServer/Makefile          |   3 +
 PVE/QemuServer/StateFile.pm      |  88 ++++++
 test/cfg2cmd/aio.conf.cmd        |  16 +-
 test/cfg2cmd/old-qemu.conf       |   4 +-
 test/run_config2command_tests.pl |  10 +
 9 files changed, 689 insertions(+), 263 deletions(-)
 create mode 100644 PVE/QemuServer/Blockdev.pm
 create mode 100644 PVE/QemuServer/StateFile.pm

-- 
2.39.5

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel