From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve_flutter_frontend v3 1/1] fix: resources: add filter option for `paused` guest status
Date: Thu, 5 Jun 2025 11:41:17 +0200 [thread overview]
Message-ID: <20250605094118.93815-2-s.shaji@proxmox.com> (raw)
In-Reply-To: <20250605094118.93815-1-s.shaji@proxmox.com>
In the resources tab there were no option to filter the guest
when the status is `paused`. To fix the issue, add new `paused`
filter option under status section of the drawer.
Additionaly rather than copy pasting the
`_ProxmoxResourceFilterLisTile`, add a for loop that will
iterate over all the statuses.
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
changes since v2:
* rebase the changes with master.
* fix commit message.
.../pve_mobile_resource_filter_sheet.dart | 40 +++++++------------
1 file changed, 15 insertions(+), 25 deletions(-)
diff --git a/lib/widgets/pve_mobile_resource_filter_sheet.dart b/lib/widgets/pve_mobile_resource_filter_sheet.dart
index cee3a49..34e169b 100644
--- a/lib/widgets/pve_mobile_resource_filter_sheet.dart
+++ b/lib/widgets/pve_mobile_resource_filter_sheet.dart
@@ -84,34 +84,24 @@ class PveMobileResourceFilterSheet extends StatelessWidget {
_PveFilterSheetSection(
sectionTitle: 'Status',
items: [
- _ProxmoxResourceFilterListTile(
- title: 'Online',
- value: state.statusFilter
- .contains(PveResourceStatusType.running),
- onChanged: (v) => rBloc.events.add(
- FilterResources(
- statusFilter: _addOrRemove(
- v!,
- PveResourceStatusType.running,
- state.statusFilter,
- ),
- ),
- ),
- ),
- _ProxmoxResourceFilterListTile(
- title: 'Offline',
- value: state.statusFilter
- .contains(PveResourceStatusType.stopped),
- onChanged: (v) => rBloc.events.add(
- FilterResources(
- statusFilter: _addOrRemove(
- v!,
- PveResourceStatusType.stopped,
- state.statusFilter,
+ for (var filterItem in [
+ (title: 'Online', type: PveResourceStatusType.running),
+ (title: 'Offline', type: PveResourceStatusType.stopped),
+ (title: 'Paused', type: PveResourceStatusType.paused)
+ ])
+ _ProxmoxResourceFilterListTile(
+ title: filterItem.title,
+ value: state.statusFilter.contains(filterItem.type),
+ onChanged: (v) => rBloc.events.add(
+ FilterResources(
+ statusFilter: _addOrRemove(
+ v!,
+ filterItem.type,
+ state.statusFilter,
+ ),
),
),
),
- ),
],
)
],
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-05 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 9:41 [pve-devel] [PATCH proxmox_dart_api_client/pve_flutter_frontend v3 0/2] " Shan Shaji
2025-06-05 9:41 ` Shan Shaji [this message]
2025-06-05 9:41 ` [pve-devel] [PATCH proxmox_dart_api_client v3 1/1] fix: ui: add missing `paused` status check Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605094118.93815-2-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal