[pve-devel] [PATCH http-server 1/3] formatter: html: remove unused code

From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH http-server 1/3] formatter: html: remove unused code
Date: Tue,  3 Jun 2025 15:04:24 +0200	[thread overview]
Message-ID: <20250603130426.2575764-1-d.csapak@proxmox.com> (raw)

the console js code was added in
 63307be (add generic formatter framework
in January 2017 and marked to be removed (in the FIXME) with
 6189d2e (Formatter/Bootstrap.pm; use configured cookie_name)
a day later.

This was never used, so simply remove it.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/PVE/APIServer/Formatter/Bootstrap.pm | 51 ------------------------
 1 file changed, 51 deletions(-)

diff --git a/src/PVE/APIServer/Formatter/Bootstrap.pm b/src/PVE/APIServer/Formatter/Bootstrap.pm
index 6be0049..be37441 100644
--- a/src/PVE/APIServer/Formatter/Bootstrap.pm
+++ b/src/PVE/APIServer/Formatter/Bootstrap.pm
@@ -7,58 +7,8 @@ use HTML::Entities;
 use JSON;
 use URI::Escape;
 
-# FIXME: remove console code??
-
 # Helpers to generate simple html pages using Bootstrap markup.
 
-my $jssrc = <<_EOJS;
-PVE.open_vm_console = function(node, vmid) {
-    console.log("open vm " + vmid + " on node " + node);
-
-    var downloadWithName = function(uri, name) {
-	var link =  jQuery('#pve_console_anchor');
-	link.attr("href", uri);
-
-	// Note: we need to tell android the correct file name extension
-	// but we do not set 'download' tag for other environments, because
-	// It can have strange side effects (additional user prompt on firefox)
-	var andriod = navigator.userAgent.match(/Android/i) ? true : false;
-	if (andriod) {
-	    link.attr("download", name);
-	}
-
-	if (document.createEvent) {
-	    var evt = document.createEvent("MouseEvents");
-	    evt.initMouseEvent('click', true, true, window, 1, 0, 0, 0, 0, false, false, false, false, 0, null);
-	    link.get(0).dispatchEvent(evt);
-	} else {
-	    link.get(0).fireEvent('onclick');
-	}
-    };
-
-    jQuery.ajax("/api2/json/console", {
-      data: { vmid: vmid, node: node },
-      headers: { CSRFPreventionToken: PVE.CSRFPreventionToken },
-      dataType: 'json',
-      type: 'POST',
-      error: function(jqXHR, textStatus, errorThrown) {
-	  // fixme: howto view JS errors ?
-	  console.log("ERROR " +  textStatus + ": " + errorThrown);
-      },
-      success:   function(data) {
-	  var raw = "[virt-viewer]\\n";
-	  jQuery.each(data.data, function(k, v) {
-	      raw += k + "=" + v + "\\n";
-	  });
-	  var url = 'data:application/x-virt-viewer;charset=UTF-8,' +
-	      encodeURIComponent(raw);
-
-	  downloadWithName(url, "pve-spice.vv");
-      }
-    });
-};
-_EOJS
-
 sub new {
     my ($class, $res, $url, $auth, $config) = @_;
 
@@ -107,7 +57,6 @@ sub body {
 
 <script type="text/javascript">
 $jssetup
-$jssrc
 </script>
 
     <style>
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

