[pve-devel] [RFC manager/lxc-syscalld/container 0/4] avoid using generic runtime directory name for pve-lxc-syscalld

From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC manager/lxc-syscalld/container 0/4] avoid using generic runtime directory name for pve-lxc-syscalld
Date: Tue, 13 May 2025 12:56:48 +0200	[thread overview]
Message-ID: <20250513105652.67403-1-f.ebner@proxmox.com> (raw)

This is intended for PVE 9.

The pve-lxc-syscalld systemd service currently uses /run/pve as a
runtime directory. This means, that when the service is restarted, the
directory will be recreated. But the /run/pve directory is not just
used as the runtime directory of this service, but also for other
things, e.g. storage tunnel and mtunnel sockets, container stderr logs
as well as pull metric cache and lock, which will be lost when the
service is restarted.

Versioned Breaks needed:

new pve-lxc-syscalld breaks old pve-container: when the experimental
'mknod' feature is used, which requires specifying the new socket path

new pve-lxc-syscalld breaks old pve-manager: /run/pve is not
automatically created in the context of pull metrics yet

I've never used systemd tmpfiles.d before, so that requires extra
scrutiny 0:)

manager:

Fiona Ebner (1):
  add tpmfiles.d config to create /run/pve directory

 configs/Makefile          | 1 +
 configs/pve-tmpfiles.conf | 2 ++
 2 files changed, 3 insertions(+)
 create mode 100644 configs/pve-tmpfiles.conf

pve-lxc-syscalld:

Fiona Ebner (2):
  service: avoid using generic runtime directory name
  d/postinst: create link to new socket location on upgrade

 debian/postinst                 | 19 +++++++++++++++++++
 etc/pve-lxc-syscalld.service.in |  4 ++--
 2 files changed, 21 insertions(+), 2 deletions(-)
 create mode 100644 debian/postinst

pve-container:

Fiona Ebner (1):
  seccomp config: adapt to new lxc-syscalld runtime directory

 src/PVE/LXC.pm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Summary over all repositories:
  5 files changed, 33 insertions(+), 3 deletions(-)

-- 
Generated by git-murpp 0.5.0

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel