[pdm-devel] [PATCH proxmox-datacenter-manager v4 15/26] metric collection: save time needed for collection run to RRD

From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager v4 15/26] metric collection: save time needed for collection run to RRD
Date: Mon, 12 May 2025 15:37:14 +0200	[thread overview]
Message-ID: <20250512133725.262263-16-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250512133725.262263-1-l.wagner@proxmox.com>

For large setups, it might be useful to know how much time was needed to
collect metrics for *all* remotes together, e.g. for making sure that
the collection interval is not exceeded.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 .../src/metric_collection/collection_task.rs  | 14 +++++
 server/src/metric_collection/rrd_task.rs      | 53 ++++++++++++++-----
 2 files changed, 55 insertions(+), 12 deletions(-)

diff --git a/server/src/metric_collection/collection_task.rs b/server/src/metric_collection/collection_task.rs
index 53def163..cad1132a 100644
--- a/server/src/metric_collection/collection_task.rs
+++ b/server/src/metric_collection/collection_task.rs
@@ -21,6 +21,7 @@ use pdm_api_types::{
 };
 use pdm_config::metric_collection::COLLECTION_SETTINGS_TYPE;
 
+use crate::metric_collection::rrd_task::CollectionStats;
 use crate::{connection, task_utils};
 
 use super::{
@@ -93,8 +94,21 @@ impl MetricCollectionTask {
                     log::debug!("starting metric collection from all remotes - triggered by timer");
 
                     if let Some(remotes) = Self::load_remote_config() {
+                        let now = Instant::now();
                         let to_fetch = remotes.iter().map(|(name, _)| name.into()).collect::<Vec<String>>();
                         self.fetch_remotes(&remotes, &to_fetch).await;
+                        let elapsed = now.elapsed();
+
+                        if let Err(err) = self.metric_data_tx.send(
+                            RrdStoreRequest::CollectionStats {
+                                timestamp: proxmox_time::epoch_i64(),
+                                stats: CollectionStats {
+                                    // TODO: use as_millis_f64 once stabilized
+                                    total_time: elapsed.as_secs_f64() * 1000.
+                                }
+                            }).await {
+                            log::error!("could not send collection stats to rrd task: {err}");
+                        }
                     }
                 }
 
diff --git a/server/src/metric_collection/rrd_task.rs b/server/src/metric_collection/rrd_task.rs
index aa1197a0..a69099c7 100644
--- a/server/src/metric_collection/rrd_task.rs
+++ b/server/src/metric_collection/rrd_task.rs
@@ -38,6 +38,13 @@ pub(super) enum RrdStoreRequest {
         /// Timestamp at which the request was done (UNIX epoch).
         request_at: i64,
     },
+    /// Store collection stats.
+    CollectionStats {
+        /// Timestamp at which the collection took place (UNIX epoch).
+        timestamp: i64,
+        /// Statistics.
+        stats: CollectionStats,
+    },
 }
 
 /// Result for a [`RrdStoreRequest`].
@@ -46,6 +53,12 @@ pub(super) struct RrdStoreResult {
     pub(super) most_recent_timestamp: i64,
 }
 
+/// Statistics for a (full) metric collection run.
+pub(super) struct CollectionStats {
+    /// Total time in ms.
+    pub(super) total_time: f64,
+}
+
 /// Task which stores received metrics in the RRD. Metric data is fed into
 /// this task via a MPSC channel.
 pub(super) async fn store_in_rrd_task(
@@ -57,7 +70,8 @@ pub(super) async fn store_in_rrd_task(
         // Involves some blocking file IO
         let res = tokio::task::spawn_blocking(move || {
             let mut most_recent_timestamp = 0;
-            let channel = match msg {
+
+            match msg {
                 RrdStoreRequest::Pve {
                     remote,
                     metrics,
@@ -71,7 +85,13 @@ pub(super) async fn store_in_rrd_task(
                     }
                     store_response_time(&cache_clone, &remote, response_time, request_at);
 
-                    channel
+                    let result = RrdStoreResult {
+                        most_recent_timestamp,
+                    };
+
+                    if channel.send(result).is_err() {
+                        log::error!("could not send RrdStoreStoreResult to metric collection task");
+                    };
                 }
                 RrdStoreRequest::Pbs {
                     remote,
@@ -86,17 +106,17 @@ pub(super) async fn store_in_rrd_task(
                     }
                     store_response_time(&cache_clone, &remote, response_time, request_at);
 
-                    channel
-                }
-            };
+                    let result = RrdStoreResult {
+                        most_recent_timestamp,
+                    };
 
-            if channel
-                .send(RrdStoreResult {
-                    most_recent_timestamp,
-                })
-                .is_err()
-            {
-                log::error!("could not send RrdStoreStoreResult to metric collection task");
+                    if channel.send(result).is_err() {
+                        log::error!("could not send RrdStoreStoreResult to metric collection task");
+                    };
+                }
+                RrdStoreRequest::CollectionStats { timestamp, stats } => {
+                    store_stats(&cache_clone, &stats, timestamp)
+                }
             };
         })
         .await;
@@ -157,6 +177,15 @@ fn store_response_time(cache: &RrdCache, remote_name: &str, response_time: f64,
     cache.update_value(&name, response_time, timestamp, DataSourceType::Gauge);
 }
 
+fn store_stats(cache: &RrdCache, stats: &CollectionStats, timestamp: i64) {
+    cache.update_value(
+        "local/metric-collection/total-time",
+        stats.total_time,
+        timestamp,
+        DataSourceType::Gauge,
+    );
+}
+
 #[cfg(test)]
 mod tests {
     use proxmox_rrd_api_types::{RrdMode, RrdTimeframe};
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

