[pdm-devel] [PATCH proxmox-datacenter-manager v3 01/26] pdm-api-types: add CollectionSettings type

From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager v3 01/26] pdm-api-types: add CollectionSettings type
Date: Wed, 16 Apr 2025 14:56:17 +0200	[thread overview]
Message-ID: <20250416125642.291552-2-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250416125642.291552-1-l.wagner@proxmox.com>

This commit adds the CollectionSettings type which holds settings for
the metric collection system. Included are collection interval, max
concurrency and upper/lower bounds for the metric collection loop.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Notes:
    Changes since v2:
      - use `_` for type casts
      - Drop max-concurrency, and delay settings for now

 lib/pdm-api-types/src/lib.rs               |  3 +
 lib/pdm-api-types/src/metric_collection.rs | 68 ++++++++++++++++++++++
 2 files changed, 71 insertions(+)
 create mode 100644 lib/pdm-api-types/src/metric_collection.rs

diff --git a/lib/pdm-api-types/src/lib.rs b/lib/pdm-api-types/src/lib.rs
index 38449071..6115e41c 100644
--- a/lib/pdm-api-types/src/lib.rs
+++ b/lib/pdm-api-types/src/lib.rs
@@ -19,6 +19,9 @@ pub use acl::*;
 mod node_config;
 pub use node_config::*;
 
+mod metric_collection;
+pub use metric_collection::*;
+
 mod proxy;
 pub use proxy::HTTP_PROXY_SCHEMA;
 
diff --git a/lib/pdm-api-types/src/metric_collection.rs b/lib/pdm-api-types/src/metric_collection.rs
new file mode 100644
index 00000000..cac643e9
--- /dev/null
+++ b/lib/pdm-api-types/src/metric_collection.rs
@@ -0,0 +1,68 @@
+//! API types for metric collection settings.
+
+use serde::{Deserialize, Serialize};
+
+use proxmox_schema::{api, Updater};
+
+/// Default metric collection interval.
+pub const DEFAULT_COLLECTION_INTERVAL: u64 = 600;
+
+/// Minimum metric collection interval.
+pub const MIN_COLLECTION_INTERVAL: u64 = 10;
+
+/// Maximum metric collection interval.
+/// PVE and PBS keep 30 minutes of metric history,
+/// maximum is set to 25 minutes to leave some headroom.
+pub const MAX_COLLECTION_INTERVAL: u64 = 1500;
+
+#[api(
+    properties: {
+        "collection-interval" : {
+            optional: true,
+            default: DEFAULT_COLLECTION_INTERVAL as _,
+            minimum: MIN_COLLECTION_INTERVAL as _,
+            maximum: MAX_COLLECTION_INTERVAL as _,
+        },
+    },
+)]
+#[derive(Clone, Default, Deserialize, Serialize, Updater)]
+#[serde(rename_all = "kebab-case")]
+/// Settings for the metric collection system.
+pub struct CollectionSettings {
+    /// Collection settings ID
+    #[updater(skip)]
+    pub id: String,
+
+    /// Interval in seconds at which to collect metrics.
+    /// The point in time at which metrics are collected
+    /// are aligned based on the collection interval. For instance,
+    /// a collection interval of 300 (5 minutes) would schedule metric collection
+    /// at 11:00:00, 11:05:00.
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub collection_interval: Option<u64>,
+}
+
+#[api]
+#[derive(Copy, Clone, Deserialize, Serialize)]
+#[serde(rename_all = "kebab-case")]
+/// Deletable property for [`CollectionSettings`].
+pub enum DeletableCollectionSettingsProperty {
+    /// Delete 'collection-interval'.
+    CollectionInterval,
+}
+
+impl CollectionSettings {
+    /// Create a new settings instance with a given `id`.
+    pub fn new(id: &str) -> Self {
+        Self {
+            id: id.into(),
+            ..Default::default()
+        }
+    }
+
+    /// Return the collection interval or the default if not configured.
+    pub fn collection_interval_or_default(&self) -> u64 {
+        self.collection_interval
+            .unwrap_or(DEFAULT_COLLECTION_INTERVAL)
+    }
+}
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

