[pve-devel] [PATCH] add patch to disable elastic_shared_blob to prevent crashing OSDs

From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH] add patch to disable elastic_shared_blob to prevent crashing OSDs
Date: Tue,  8 Apr 2025 12:39:04 +0200	[thread overview]
Message-ID: <20250408103904.1798122-1-s.ivanov@proxmox.com> (raw)

reported in our community forum and upstream:
https://forum.proxmox.com/threads/164735/
https://tracker.ceph.com/issues/70390
https://github.com/ceph/ceph/pull/62724

fix seems trivial, and the feature is quite new:
https://ceph.io/assets/pdfs/events/2024/ceph-days-nyc/Diving%20Deep%20with%20Squid.pdf

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
the commit message was re-used for both the patch-file and the commit itself
hope that's ok?

did not build this - as it'd take quite long. only verified that this
setting is set to true (for all OSDs irrespective when they were created)
with our current packages:
```
ceph config get osd.5 bluestore_elastic_shared_blobs
true
```
(on a testcluster of mine)

 ...shared_blob-to-prevent-crashing-OSDs.patch | 31 +++++++++++++++++++
 patches/series                                |  1 +
 2 files changed, 32 insertions(+)
 create mode 100644 patches/0018-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch

diff --git a/patches/0018-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch b/patches/0018-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
new file mode 100644
index 000000000..527df2cd7
--- /dev/null
+++ b/patches/0018-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
@@ -0,0 +1,31 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Stoiko Ivanov <s.ivanov@proxmox.com>
+Date: Tue, 8 Apr 2025 12:13:10 +0200
+Subject: [PATCH] disable elastic_shared_blob to prevent crashing OSDs
+
+reported in our community forum and upstream:
+https://forum.proxmox.com/threads/164735/
+https://tracker.ceph.com/issues/70390
+https://github.com/ceph/ceph/pull/62724
+
+fix seems trivial, and the feature is quite new:
+https://ceph.io/assets/pdfs/events/2024/ceph-days-nyc/Diving%20Deep%20with%20Squid.pdf
+
+Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
+---
+ ceph/src/common/options/global.yaml.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/common/options/global.yaml.in b/ceph/src/common/options/global.yaml.in
+index 76a4f4d9551ada1ce20913197dab2b0bdb716b5c..c9b76d378aa7226944e8c0edb14956ad1265a4ae 100644
+--- a/src/common/options/global.yaml.in
++++ b/src/common/options/global.yaml.in
+@@ -4952,7 +4952,7 @@ options:
+   long_desc: Overwrites on snapped objects cause shared blob count to grow.
+     It has a very negative performance effect. When enabled shared blob count
+     is significantly reduced.
+-  default: true
++  default: false
+   flags:
+   - create
+   with_legacy: false
diff --git a/patches/series b/patches/series
index 994ff174d..6d01dcc02 100644
--- a/patches/series
+++ b/patches/series
@@ -15,3 +15,4 @@
 0015-debian-pkg-record-python3-packaging-dependency-for-c.patch
 0016-d-control-fix-lua-dependencies-for-librgw2.patch
 0017-common-pick_address-Add-IPv6-support-to-is_addr_in_s.patch
+0018-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

