[pve-devel] [PATCH v2 qemu-server 2/4] migration: drop removed 'compress' capability

From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 qemu-server 2/4] migration: drop removed 'compress' capability
Date: Mon,  7 Apr 2025 09:32:54 +0200	[thread overview]
Message-ID: <20250407073256.8889-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250407073256.8889-1-f.ebner@proxmox.com>

This was added by commit b62532e4 ("migration: disable compress")
stating:

> it's already disable by default,
> but we want to be sure if it's change in later release

QEMU never did change the default (verified with QEMU 8.0 and that
would be would've been a breaking change from QEMU's side).

The 'compress' capability was removed in QEMU 9.1, with QEMU commit
0222111a22 ("migration: Remove non-multifd compression").

The function to set migration capabilities already queries which ones
are supported by the currently running QEMU and ignores others, so
there was no error about 'compress'.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7bd38dbc..cef6d068 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4617,7 +4617,6 @@ sub set_migration_caps {
 	"xbzrle" => 1,
 	"x-rdma-pin-all" => 0,
 	"zero-blocks" => 0,
-	"compress" => 0,
 	"dirty-bitmaps" => $dirty_bitmaps,
     };
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

