From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH] ui tasks: use view task instead of open task
Date: Mon, 18 Nov 2024 11:49:59 +0100 [thread overview]
Message-ID: <20241118104959.95159-1-a.lauterer@proxmox.com> (raw)
This aligns the tooltips to how we have in in Proxmox VE. Using "view"
instead of "open" should make it clear, that this is a safe read-only
action.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
Matching patches for PVE in the pve-devel list:
https://lore.proxmox.com/pve-devel/20241118104530.91798-1-a.lauterer@proxmox.com/T/#t
www/dashboard/LongestTasks.js | 2 +-
www/dashboard/RunningTasks.js | 2 +-
www/dashboard/TaskSummary.js | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/dashboard/LongestTasks.js b/www/dashboard/LongestTasks.js
index 20cf1183..f405b98f 100644
--- a/www/dashboard/LongestTasks.js
+++ b/www/dashboard/LongestTasks.js
@@ -100,7 +100,7 @@ Ext.define('PBS.LongestTasks', {
items: [
{
iconCls: 'fa fa-chevron-right',
- tooltip: gettext('Open Task'),
+ tooltip: gettext('View Task'),
handler: 'openTaskActionColumn',
},
],
diff --git a/www/dashboard/RunningTasks.js b/www/dashboard/RunningTasks.js
index 4529d0d3..20a7c51e 100644
--- a/www/dashboard/RunningTasks.js
+++ b/www/dashboard/RunningTasks.js
@@ -95,7 +95,7 @@ Ext.define('PBS.RunningTasks', {
items: [
{
iconCls: 'fa fa-chevron-right',
- tooltip: gettext('Open Task'),
+ tooltip: gettext('View Task'),
handler: 'openTaskActionColumn',
},
],
diff --git a/www/dashboard/TaskSummary.js b/www/dashboard/TaskSummary.js
index 68f6f6ef..684a18f0 100644
--- a/www/dashboard/TaskSummary.js
+++ b/www/dashboard/TaskSummary.js
@@ -109,7 +109,7 @@ Ext.define('PBS.TaskSummary', {
items: [
{
iconCls: 'fa fa-chevron-right',
- tooltip: gettext('Open Task'),
+ tooltip: gettext('View Task'),
handler: function(g, rowIndex) {
let rec = tasklist.getStore().getAt(rowIndex);
tasklist.setVisible(false);
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-11-18 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 10:49 Aaron Lauterer [this message]
2025-04-09 10:52 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118104959.95159-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal