From: Dominik Csapak <d.csapak@proxmox.com>
To: Nicolas Frey <n.frey@proxmox.com>, yew-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-yew-widget-toolkit 5/5] widget: form: combobox: update doc to point to `MultiSelect`
Date: Mon, 2 Nov 2026 15:12:19 +0100 [thread overview]
Message-ID: <d22c5692-2414-4f46-ac2e-a6ecd5d74c3d@proxmox.com> (raw)
In-Reply-To: <20261028151517.518742-6-n.frey@proxmox.com>
i would fold this patch into the previous patch
On 10/28/26 4:15 PM, Nicolas Frey wrote:
> mention it in the note about missing multi-select support, so users
> find it more easily.
>
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
> src/widget/form/combobox.rs | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/widget/form/combobox.rs b/src/widget/form/combobox.rs
> index 7de2906..94f997a 100644
> --- a/src/widget/form/combobox.rs
> +++ b/src/widget/form/combobox.rs
> @@ -30,8 +30,9 @@ use pwt_macros::{builder, widget};
> /// there is not enough room to display the selected values when the combobox
> /// is collapsed. Therefore, we have not implemented the multiselect mode.
> ///
> -/// Please consider using a flat grid instead. If there are few choices,
> -/// a segmented button may also be an option.
> +/// If only a few values are expected to be selected at once, consider using
> +/// [MultiSelect](super::MultiSelect). Otherwise, please consider using a flat grid
> +/// instead. If there are few choices, a segmented button may also be an option.
> #[widget(pwt=crate, comp=PwtCombobox, @input)]
> #[derive(Clone, PartialEq, Properties)]
> #[builder]
next prev parent reply other threads:[~2026-11-02 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:15 [PATCH proxmox-yew-widget-toolkit 0/5] add multi-select component Nicolas Frey
2026-10-28 15:15 ` [PATCH proxmox-yew-widget-toolkit 1/5] widget: data table: simplify lookup of keys near the cursor Nicolas Frey
2026-11-02 14:12 ` Dominik Csapak
2026-10-28 15:15 ` [PATCH proxmox-yew-widget-toolkit 2/5] widget: data table: only extend explicit select all to new rows Nicolas Frey
2026-11-02 14:12 ` Dominik Csapak
2026-10-28 15:15 ` [PATCH proxmox-yew-widget-toolkit 3/5] widget: grid picker: keep selected records hidden by the filter Nicolas Frey
2026-11-02 14:12 ` Dominik Csapak
2026-10-28 15:15 ` [PATCH proxmox-yew-widget-toolkit 4/5] widget: form: implement multi select field Nicolas Frey
2026-11-02 14:12 ` Dominik Csapak
2026-11-02 14:23 ` Dominik Csapak
2026-10-28 15:15 ` [PATCH proxmox-yew-widget-toolkit 5/5] widget: form: combobox: update doc to point to `MultiSelect` Nicolas Frey
2026-11-02 14:12 ` Dominik Csapak [this message]
2026-11-02 14:12 ` [PATCH proxmox-yew-widget-toolkit 0/5] add multi-select component Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d22c5692-2414-4f46-ac2e-a6ecd5d74c3d@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=n.frey@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox