From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yew-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id AB19F1FF14F
	for <inbox@lore.proxmox.com>; Fri, 08 May 2026 18:11:51 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 6F55B1DB20;
	Fri,  8 May 2026 18:11:51 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 08 May 2026 18:11:17 +0200
Message-Id: <DIDFDS0GT0A5.1TOY4SARFUCUX@proxmox.com>
Subject: Re: [PATCH yew-mobile-gui v2 12/21] dashboard: use proper plural
 translation string instead of "CPU(s)"
From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <yew-devel@lists.proxmox.com>
X-Mailer: aerc 0.20.0
References: <20260508155722.464564-1-s.sterz@proxmox.com>
 <20260508155722.464564-13-s.sterz@proxmox.com>
In-Reply-To: <20260508155722.464564-13-s.sterz@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1778256568872
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.150 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: WQN5QXXFBMFW2SFHDFMLDETV65OFCOQF
X-Message-ID-Hash: WQN5QXXFBMFW2SFHDFMLDETV65OFCOQF
X-MailFrom: s.shaji@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Yew framework devel list at Proxmox <yew-devel.lists.proxmox.com>
List-Help: <mailto:yew-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:yew-devel-owner@lists.proxmox.com>
List-Post: <mailto:yew-devel@lists.proxmox.com>
List-Subscribe: <mailto:yew-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:yew-devel-leave@lists.proxmox.com>

Hi,

Applied this patch and tested the change. The pluralization works correctly
now.=20

Tested-by: Shan Shaji <s.shaji@proxmox.com>

On Fri May 8, 2026 at 5:57 PM CEST, Shannon Sterz wrote:
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  src/pages/page_dashboard.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/pages/page_dashboard.rs b/src/pages/page_dashboard.rs
> index 519b22e..1e0243f 100644
> --- a/src/pages/page_dashboard.rs
> +++ b/src/pages/page_dashboard.rs
> @@ -132,7 +132,7 @@ impl PvePageDashboard {
>                  tiles.push(
>                      icon_list_tile(Fa::new("cpu"), tr!("CPU"), (), ()).w=
ith_child(list_tile_usage(
>                          tr!("{0}%", format!("{:.2}", cpu_proportion * 10=
0.0)),
> -                        tr!("{0} CPU(s)", maxcpu.to_string()),
> +                        tr!("1 CPU" | "{n} CPUs" % maxcpu).to_string(),
>                          cpu_proportion,
>                      )),
>                  );