From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 611A71FF15C for ; Fri, 27 Jun 2025 16:40:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E6EC917198; Fri, 27 Jun 2025 16:40:42 +0200 (CEST) Mime-Version: 1.0 Date: Fri, 27 Jun 2025 16:40:10 +0200 To: "Dietmar Maurer" , "Yew framework devel list at Proxmox" , "Dominik Csapak" Message-Id: X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250627120859.3723554-1-d.csapak@proxmox.com> <20250627120859.3723554-12-d.csapak@proxmox.com> <1941150137.9773.1751034747283@webmail.proxmox.com> In-Reply-To: <1941150137.9773.1751034747283@webmail.proxmox.com> From: "Shannon Sterz" X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [yew-devel] [PATCH yew-widget-toolkit 05/11] touch: material app: allow pass through of page animation style X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" On Fri Jun 27, 2025 at 4:32 PM CEST, Dietmar Maurer wrote: > >> could we implement `Default` on `PageAnimationStyle` here and remove the >> `Option`? that would also clean up the code below a bit. or is there a >> reason not to do that? > > I guess we want to be able to set it to None (no animation)... but the code that uses this property below calls `unwrap_or` with `PageAnimationStyle::Push`. this means setting `None` here would still result in the `Push` animation style (or for that matter, not specifying an animation style at all). so yeah if that's the desired behavior, then the `unwrap_or` here: >>> + .with_child( >>> + PageStack::new(page_stack) >>> + .animation_style(props.page_animation.unwrap_or(PageAnimationStyle::Push)), >>> + ) >>> would need to be removed. ps: sorry resend this one as the list got dropped previously _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel