From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yew-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 7ABB21FF15E
for <inbox@lore.proxmox.com>; Tue, 6 May 2025 14:26:36 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 591159E7D;
Tue, 6 May 2025 14:26:53 +0200 (CEST)
Mime-Version: 1.0
Date: Tue, 06 May 2025 14:26:19 +0200
Message-Id: <D9P2RLFBAG4P.2F38VPJUNR0E1@proxmox.com>
To: "Yew framework devel list at Proxmox" <yew-devel@lists.proxmox.com>,
"Dominik Csapak" <d.csapak@proxmox.com>
X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty
References: <20250506115423.170353-1-s.sterz@proxmox.com>
<4cf65416-049f-496a-8f8a-cdce4b7d1c8b@proxmox.com>
In-Reply-To: <4cf65416-049f-496a-8f8a-cdce4b7d1c8b@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.019 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [yew-devel] [PATCH yew-widget-toolkit v1 1/2] store: use
try_borrow and expect_throw for better error messages
X-BeenThere: yew-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Yew framework devel list at Proxmox <yew-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/yew-devel/>
List-Post: <mailto:yew-devel@lists.proxmox.com>
List-Help: <mailto:yew-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: yew-devel-bounces@lists.proxmox.com
Sender: "yew-devel" <yew-devel-bounces@lists.proxmox.com>
On Tue May 6, 2025 at 2:21 PM CEST, Dominik Csapak wrote:
> On 5/6/25 13:54, Shannon Sterz wrote:
>> this makes use of the `UnwrapThrowExt` trait to improve error messages
>
> nit: this is not true anymore in v1
>
> could maybe fixed up on applying though
yes missed that sorry, will send a v2
>
>> when acquring store locks. taking such locks in async functions can
>> sometimes lead to bugs that can be unreliably reproduced, this should
>> provide more information about the source of the error compared to
>> just panicking.
>>
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>> src/state/store.rs | 11 +++++++++--
>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/state/store.rs b/src/state/store.rs
>> index bde7d9da..67e72b77 100644
>> --- a/src/state/store.rs
>> +++ b/src/state/store.rs
>> @@ -130,7 +130,10 @@ impl<T: 'static> Store<T> {
>> /// Panics if the value is currently mutably locked.
>> pub fn read(&self) -> StoreReadGuard<T> {
>> StoreReadGuard {
>> - state: self.inner.borrow(),
>> + state: self
>> + .inner
>> + .try_borrow()
>> + .expect("Could not acquire read lock on store!"),
>> }
>> }
>>
>> @@ -142,7 +145,11 @@ impl<T: 'static> Store<T> {
>> /// When the returned [StoreWriteGuard] is dropped, the store listeners
>> /// are notified. To prevent that use [StoreWriteGuard::skip_update]
>> pub fn write(&self) -> StoreWriteGuard<T> {
>> - let state = self.inner.borrow_mut();
>> + let state = self
>> + .inner
>> + .try_borrow_mut()
>> + .expect("Could not acquire write lock on store!");
>> +
>> StoreWriteGuard {
>> state,
>> update: true,
>
>
>
> _______________________________________________
> yew-devel mailing list
> yew-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel