From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yew-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 869C71FF162
for <inbox@lore.proxmox.com>; Mon, 5 May 2025 10:27:55 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 86E5EEE5A;
Mon, 5 May 2025 10:28:11 +0200 (CEST)
Mime-Version: 1.0
Date: Mon, 05 May 2025 10:27:35 +0200
Message-Id: <D9O329K5GHT7.1P06RMSHIJ4BA@proxmox.com>
To: "Yew framework devel list at Proxmox" <yew-devel@lists.proxmox.com>,
"Dietmar Maurer" <dietmar@proxmox.com>
X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty
References: <20250502124951.3886328-1-d.csapak@proxmox.com>
<675478941.9677.1746432824405@webmail.proxmox.com>
In-Reply-To: <675478941.9677.1746432824405@webmail.proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.383 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible
spam tricks
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
KAM_SHORT 0.001 Use of a URL Shortener for very short URL
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [yew-devel] [PATCH yew-widget-toolkit 1/2] dom: add convenience
functions to get often used elements
X-BeenThere: yew-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Yew framework devel list at Proxmox <yew-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/yew-devel/>
List-Post: <mailto:yew-devel@lists.proxmox.com>
List-Help: <mailto:yew-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: yew-devel-bounces@lists.proxmox.com
Sender: "yew-devel" <yew-devel-bounces@lists.proxmox.com>
On Mon May 5, 2025 at 10:13 AM CEST, Dietmar Maurer wrote:
> We can use gloo_utils instead?
>
I'd also prefer gloo_utils here, especially because that also uses the
`UnwraptThrowExt` traits, which is a bit nicer [1] and pwt already
depends on it indirectly anyway (through, e.g., gloo-history).
[1]: https://docs.rs/gloo-utils/latest/src/gloo_utils/lib.rs.html
>> On 2.5.2025 14:49 CEST Dominik Csapak <d.csapak@proxmox.com> wrote:
>>
>>
>> Namely window/document/body. We use them throughout our codebase with
>> inline unwraps, instead we can use these helpers instead.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> src/dom/mod.rs | 20 +++++++++++++++++++-
>> 1 file changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/dom/mod.rs b/src/dom/mod.rs
>> index f61dd21..679fab7 100644
>> --- a/src/dom/mod.rs
>> +++ b/src/dom/mod.rs
>> @@ -13,7 +13,7 @@ pub use dom_size_observer::{DomSizeObserver, IntoSizeCallback, SizeCallback};
>> mod dom_visibility_observer;
>> pub use dom_visibility_observer::DomVisibilityObserver;
>>
>> -use web_sys::Node;
>> +use web_sys::{window, Document, HtmlElement, Node, Window};
>> use yew::prelude::*;
>>
>> /// A Trait to convert structs into HtmlElement when possible
>> @@ -77,3 +77,21 @@ pub fn get_system_prefer_dark_mode() -> bool {
>> false
>> }
>> }
>> +
>> +/// Convenience function to get the [`Window`] object.
>> +/// Panics if not in a browser context
>> +pub fn get_window() -> Window {
>> + window().unwrap()
>> +}
>> +
>> +/// Convenience function to get the [`Document`] object.
>> +/// Panics if not in a browser context
>> +pub fn get_document() -> Document {
>> + get_window().document().unwrap()
>> +}
>> +
>> +/// Convenience function to get the a reference to the <body> tag as [`HtmlElement`].
>> +/// Panics if not in a browser context
>> +pub fn get_body() -> HtmlElement {
>> + get_document().body().unwrap()
>> +}
>> --
>> 2.39.5
>>
>>
>>
>> _______________________________________________
>> yew-devel mailing list
>> yew-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
>
>
> _______________________________________________
> yew-devel mailing list
> yew-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel