From: Dominik Csapak <d.csapak@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>, yew-devel@lists.proxmox.com
Subject: Re: [RFC yew-comp/yew-widget-toolkit/yew-widget-toolkit-assets 0/3] minor ui/ux tweaks for pwt and yew-comp
Date: Wed, 6 May 2026 11:55:16 +0200 [thread overview]
Message-ID: <824a0c3b-3784-4d6b-bb89-a64332106cb8@proxmox.com> (raw)
In-Reply-To: <DIBHVGHHYD5F.1GM39MBLT74QT@proxmox.com>
On 5/6/26 11:41 AM, Shannon Sterz wrote:
> On Wed May 6, 2026 at 9:53 AM CEST, Dominik Csapak wrote:
>>
>>
>> On 5/4/26 4:38 PM, Shannon Sterz wrote:
>>> this series includes two minor tweaks that should improve the usability and
>>> user experience of some yew components.
>>>
>>> dropdowns should now render their pickers below or above the component
>>> depending on the size of the picker and available screen space. a dropup mode
>>> improves usability for filter fields when the picker is rendered above the
>>> dropdown.
>>>
>>> the log view in the syslog and task log components was slightly tweaked to avoid
>>> interference between scrollbars and drag handles.
>>
>> this looks fine to me
>>
>>>
>>> mainly sending this as rfc for now to get feedback on how the dropdown/dropup
>>> is handled here.
>>>
>>
>> i thought a bit about this, and since the picker in the dropdown is
>> relatively generic, i think it's dangerous to simply reverse
>> the flex direction.
>>
>> we have no idea what the user of a dropdown renders, and if it's
>> e.g. simply sorted list of flex items, that order would be reversed
>> when it would be displayed above?
>>
>> imho what we could do is to expose the position (if possible) to the
>> DropdownController, and the picker renderer can react to that change
>> (by e.g. putting the filter on the bottom manually)
>>
>> wdyt?
>
> yep sounds good. i'd keep using a reverse column instead of changing the
> markup itself tho. for two reasons:
>
> - it makes more semantic sense to me for the filter input field to still
> be the first one in the picker (this also mean the tab order is
> "correct").
> - scrolling behavior is better, browsers will scroll the picker to its
> bottom by default.
>
> we could correct these manually too ofc, but i don't really see the
> upside here. i will drop the first patch of this series and implement
> this behavior in the `GridPicker` component, though.
>
yes, how the picker decides what to render first is not really
important, so if we can reverse the flex order there it's fine
i'd only want to avoid that we reverse the flex order when we don't have
any information or control over what is actually rendered
>>> pwt-assets:
>>>
>>> Shannon Sterz (1):
>>> dropdown: add class for dropup mode
>>>
>>> scss/_dropdown.scss | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>>
>>> pwt:
>>>
>>> Shannon Sterz (1):
>>> dropdown/align: make the picker render above or below a dropdown
>>>
>>> src/dom/align.rs | 6 +++-
>>> src/widget/dropdown.rs | 62 +++++++++++++++++++++++++++++++++++-------
>>> 2 files changed, 57 insertions(+), 11 deletions(-)
>>>
>>>
>>> yew-comp:
>>>
>>> Shannon Sterz (1):
>>> task_viewer/syslog: make padding margin to improve ux
>>>
>>> src/syslog.rs | 2 +-
>>> src/task_viewer.rs | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>>
>>> Summary over all repositories:
>>> 5 files changed, 63 insertions(+), 13 deletions(-)
>>>
>
next prev parent reply other threads:[~2026-05-06 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 14:39 [RFC yew-comp/yew-widget-toolkit/yew-widget-toolkit-assets 0/3] minor ui/ux tweaks for pwt and yew-comp Shannon Sterz
2026-05-04 14:39 ` [PATCH yew-widget-toolkit-assets 1/3] dropdown: add class for dropup mode Shannon Sterz
2026-05-04 14:39 ` [PATCH yew-widget-toolkit 2/3] dropdown/align: make the picker render above or below a dropdown Shannon Sterz
2026-05-04 14:39 ` [PATCH yew-comp 3/3] task_viewer/syslog: make padding margin to improve ux Shannon Sterz
2026-05-06 7:53 ` [RFC yew-comp/yew-widget-toolkit/yew-widget-toolkit-assets 0/3] minor ui/ux tweaks for pwt and yew-comp Dominik Csapak
2026-05-06 9:43 ` Shannon Sterz
2026-05-06 9:55 ` Dominik Csapak [this message]
2026-05-06 9:56 ` Superseded: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=824a0c3b-3784-4d6b-bb89-a64332106cb8@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=s.sterz@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox