From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 04EBF1FF13C for ; Thu, 02 Apr 2026 08:27:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 207E78F35; Thu, 2 Apr 2026 08:27:57 +0200 (CEST) Message-ID: <68c42b44-f869-4054-9076-4091b51c3a9e@proxmox.com> Date: Thu, 2 Apr 2026 08:27:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH yew-comp] wizard: make content panel resizable too if wizard parent is To: Christoph Heiss , yew-devel@lists.proxmox.com References: <20260401143416.2144615-1-c.heiss@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260401143416.2144615-1-c.heiss@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775111183276 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.457 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WPLH27ZSHNIT4TBQLB2YWADC4JAGM2CO X-Message-ID-Hash: WPLH27ZSHNIT4TBQLB2YWADC4JAGM2CO X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: didn't test it, but is there any argument against always setting that class? On 4/1/26 4:33 PM, Christoph Heiss wrote: > Without this, the content panel won't be resized together with the > parent wizard dialog, staying static and not filling the dialog content > area. > > Signed-off-by: Christoph Heiss > --- > src/wizard.rs | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/wizard.rs b/src/wizard.rs > index 7d83da1..6d1d02a 100644 > --- a/src/wizard.rs > +++ b/src/wizard.rs > @@ -8,7 +8,7 @@ use html::Scope; > use indexmap::IndexMap; > use serde_json::{json, Value}; > > -use pwt::css::{Flex, Overflow}; > +use pwt::css::{self, Flex, Overflow}; > use pwt::props::RenderFn; > use pwt::{prelude::*, AsyncPool}; > > @@ -553,7 +553,10 @@ impl Component for PwtWizard { > tab_panel.add_item(tab_bar_item, page_content); > } > > - let tab_panel = Mask::new(tab_panel).visible(self.loading); > + let mut tab_panel = Mask::new(tab_panel).visible(self.loading); > + if props.resizable { > + tab_panel.add_class(css::FlexFit); > + } > > Container::new() > .with_child(