From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AF3F21FF136 for ; Mon, 09 Mar 2026 13:54:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B4AA933187; Mon, 9 Mar 2026 13:54:44 +0100 (CET) Message-ID: <591b094a-7451-48ec-9683-d679d46b1705@proxmox.com> Date: Mon, 9 Mar 2026 13:54:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH yew-comp 00/15] clippy clean up proxmox-yew-comp To: Shannon Sterz , yew-devel@lists.proxmox.com References: <20260306112148.208189-1-s.sterz@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260306112148.208189-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773060846700 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HJIXOIX5WT2BOSHX3RKOTML7RWDEL7MY X-Message-ID-Hash: HJIXOIX5WT2BOSHX3RKOTML7RWDEL7MY X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: most of them look fine to me IMO, but I'm thinking maybe we should have (for the gui at least?) a custom clippy config that removes some default lints, e.g. the large_enum_variant and too_many_arguments lint don' gain us much most of the time (Msg enums are only sent every once in a while, so performance impact is negligible here; long argument lists only get ignored most of the time anyway) also the commit: fix various minor clippy lints has some in the list that are not actually part of the commit? (like again the 'too_many_arguments' one) so before i go and apply this (at least partially) we might want to look over the lints again to see which one we can/should ignore here? On 3/6/26 12:21 PM, Shannon Sterz wrote: > these patches clean up all clippy warning in proxmox-yew-comp. see each > patch for a description which lints are being cleaned up. > > > Shannon Sterz (15): > tree wide: fix clippy lint "useless_conversion" > tree wide: fix clippy lint "new_without_default" > tree wide: fix clippy lint "redundant_static_lifetimes" > tree wide: fix clippy lint "unnecessary_lazy_evaluations" > tree wide: fix clippy lint "unwrap_or_default" > tree wide: fix clippy lint "clone_on_copy" > tree wide: fix clippy lint "collapsible_else_if" > tree wide: fix various minor clippy lints > tree wide: fix clippy lint "manual_strip" > lxc_property/qemu_property: fix clippy lint "match_like_matches_macro" > firewall_property: fix clippy lint "redundant_guards" > qemu_property: fix clippy lint "redundant_pattern_matching" > qemu_hardware_pane/lxc_resources_panel: allow > clippy::enum_variant_names > tree wide: fix clippy lint "large_enum_variant" > tree wide: allow clippy "too_many_arguments" warning selectively > > .../firewall_options_cluster_panel.rs | 6 + > .../pve/firewall/firewall_rules_panel.rs | 4 +- > src/configuration/pve/lxc_network_panel.rs | 15 ++- > .../pve/lxc_resources_panel/desktop.rs | 4 +- > .../pve/lxc_resources_panel/mobile.rs | 4 +- > .../pve/lxc_resources_panel/mod.rs | 1 + > .../reassign_volume_dialog.rs | 16 +-- > src/configuration/pve/move_disk_dialog.rs | 12 +- > .../pve/qemu_hardware_panel/desktop.rs | 6 +- > .../pve/qemu_hardware_panel/mobile.rs | 6 +- > .../pve/qemu_hardware_panel/mod.rs | 1 + > .../reassign_disk_dialog.rs | 14 +-- > src/editable_property.rs | 2 +- > src/form/pve/boot_device_list.rs | 6 +- > .../firewall_property/log_level_selector.rs | 6 + > .../log_ratelimit_property.rs | 13 +- > .../log_ratelimit_selector.rs | 12 +- > src/form/pve/firewall_property/mod.rs | 6 +- > src/form/pve/hotplug_feature_selector.rs | 18 +-- > src/form/pve/lxc_mount_options_selector.rs | 10 +- > .../pve/lxc_property/lxc_cores_property.rs | 8 +- > .../pve/lxc_property/lxc_features_property.rs | 27 ++-- > .../lxc_property/lxc_memory_swap_property.rs | 4 +- > .../lxc_property/lxc_mount_point_property.rs | 99 +++++++-------- > .../lxc_property/lxc_nameserver_property.rs | 4 +- > .../pve/lxc_property/lxc_network_property.rs | 36 +++--- > src/form/pve/mod.rs | 4 +- > src/form/pve/pve_guest_selector.rs | 14 ++- > src/form/pve/pve_network_selector.rs | 11 +- > src/form/pve/pve_storage_content_selector.rs | 12 +- > src/form/pve/pve_vlan_field.rs | 6 + > src/form/pve/qemu_cache_type_selector.rs | 6 + > src/form/pve/qemu_controller_selector.rs | 6 + > src/form/pve/qemu_cpu_flags_list.rs | 22 ++-- > src/form/pve/qemu_disk_format_selector.rs | 11 +- > .../pve/qemu_disk_size_format_selector.rs | 12 +- > src/form/pve/qemu_display_type_selector.rs | 6 + > src/form/pve/qemu_machine_version_selector.rs | 18 +-- > src/form/pve/qemu_ostype_selector.rs | 6 + > src/form/pve/qemu_property/mod.rs | 2 +- > .../qemu_property/qemu_amd_sev_property.rs | 18 +-- > .../pve/qemu_property/qemu_disk_property.rs | 119 +++++++++--------- > .../qemu_property/qemu_display_property.rs | 4 +- > .../qemu_property/qemu_efidisk_property.rs | 28 +++-- > .../qemu_property/qemu_intel_tdx_property.rs | 12 +- > .../pve/qemu_property/qemu_memory_property.rs | 17 ++- > .../qemu_property/qemu_processor_property.rs | 4 +- > .../pve/qemu_property/qemu_scsihw_property.rs | 4 +- > .../qemu_property/qemu_smbios1_property.rs | 2 +- > .../qemu_spice_enhancement_property.rs | 4 +- > .../qemu_property/qemu_tpmstate_property.rs | 21 ++-- > src/layout/mobile_form.rs | 4 +- > src/loadable_component.rs | 6 + > src/log_view.rs | 2 +- > src/pending_property_view/mod.rs | 6 + > src/property_edit_dialog.rs | 4 +- > src/property_view/mod.rs | 6 +- > src/utils/task_descriptions.rs | 4 +- > 58 files changed, 414 insertions(+), 327 deletions(-) > > -- > 2.47.3 > > > > >