From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id B28AB1FF0E1 for ; Wed, 26 Aug 2026 08:43:49 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1E8F22081B; Wed, 26 Aug 2026 08:43:49 +0200 (CEST) Message-ID: <58428142-fbc3-429f-ac11-2cf28a044504@proxmox.com> Date: Wed, 26 Aug 2026 08:43:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-yew-comp] fix #7932: add missing uptime to the GUI To: Shan Shaji , yew-devel@lists.proxmox.com References: <20260825135425.329949-1-s.shaji@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260825135425.329949-1-s.shaji@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787726592547 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.557 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: W5VJQCS5IYQZIQAPAEGO47KRYPVOA3FI X-Message-ID-Hash: W5VJQCS5IYQZIQAPAEGO47KRYPVOA3FI X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: see one comment inline On 8/25/26 3:54 PM, Shan Shaji wrote: > Previously, the uptime was not displayed in Proxmox Datacenter Manager. > This fixes the issue by wiring the property already available from > the /status endpoint into the UI. > > Signed-off-by: Shan Shaji > --- > src/node_status_panel.rs | 25 +++++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/src/node_status_panel.rs b/src/node_status_panel.rs > index ec17a94..d1a02c2 100644 > --- a/src/node_status_panel.rs > +++ b/src/node_status_panel.rs > @@ -8,13 +8,13 @@ use pwt::widget::form::DisplayField; > use yew::virtual_dom::{VComp, VNode}; > > use pwt::prelude::*; > -use pwt::widget::{error_message, Fa, Panel, Row, Tooltip}; > +use pwt::widget::{Container, Fa, Panel, Row, Tooltip, error_message}; > use pwt::widget::{Button, Dialog}; > use pwt_macros::builder; > > use proxmox_node_status::{NodePowerCommand, NodeStatus}; > > -use crate::utils::copy_text_to_clipboard; > +use crate::utils::{copy_text_to_clipboard, format_duration_human}; > use crate::{ > http_get, http_post, node_info, ConfirmButton, LoadableComponent, LoadableComponentContext, > LoadableComponentMaster, LoadableComponentScopeExt, LoadableComponentState, > @@ -146,6 +146,26 @@ impl ProxmoxNodeStatusPanel { > } > } > > +fn uptime_html(node_status: Option<&node_info::NodeStatus>) -> Option { > + let uptime = match node_status { nit: whitespace issue after '=' please rustfmt your code before sending > + Some(node_info::NodeStatus::Pve(node_status)) => node_status > + .additional_properties > + .get("uptime") > + .and_then(|uptime| uptime.as_u64()) > + .unwrap_or_default(), the better way would be to properly add the uptime field to the return schema in pve-manager. Then we have to update pve-api-types to include the 'uptime' field and then we can simply use it here. IMO the issue is not so pressing that we have to circumvent this schema update -> api-types update dance. while i looked at the code in pve-manager where we return this, I noticed that we always return an 'idle' field with value 0. we do read the idle value from /proc/uptime there, but don't assign it to the return value. Maybe that is something you can fix too (in a separate patch, also adding the idle field to the return schema) > + Some(node_info::NodeStatus::Pbs(node_status)) => node_status.uptime, > + Some(node_info::NodeStatus::Common(node_status)) => node_status.uptime, > + None => 0 > + }; > + > + if uptime == 0 { > + return None; > + } > + > + let uptime_string = tr!("(Uptime: {})", format_duration_human(uptime as f64)); > + Some(Container::from_tag("span").with_child(uptime_string).into()) > +} > + > impl LoadableComponent for ProxmoxNodeStatusPanel { > type Message = Msg; > type ViewState = ViewState; > @@ -229,6 +249,7 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { > .gap(2) > .with_child(Fa::new("book")) > .with_child(tr!("Node Status")) > + .with_optional_child(uptime_html(status.as_ref())) > .into_html(), > ) > .with_child(node_info(status))