From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yew-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 31FD21FF187
for <inbox@lore.proxmox.com>; Wed, 7 May 2025 10:23:30 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id AF766362BF;
Wed, 7 May 2025 10:23:47 +0200 (CEST)
Message-ID: <51a2cd86-24de-4a98-b688-7b7510d7ad7e@proxmox.com>
Date: Wed, 7 May 2025 10:23:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Shannon Sterz <s.sterz@proxmox.com>,
Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
References: <20250506132633.2898717-1-d.csapak@proxmox.com>
<20250506132633.2898717-3-d.csapak@proxmox.com>
<D9PS2B3I565C.3JIQI14XCATTR@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <D9PS2B3I565C.3JIQI14XCATTR@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [wizard.rs]
Subject: Re: [yew-devel] [PATCH yew-comp 3/4] wizard: optimize enbaled check
for next button
X-BeenThere: yew-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Yew framework devel list at Proxmox <yew-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/yew-devel/>
List-Post: <mailto:yew-devel@lists.proxmox.com>
List-Help: <mailto:yew-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: yew-devel-bounces@lists.proxmox.com
Sender: "yew-devel" <yew-devel-bounces@lists.proxmox.com>
On 5/7/25 10:15, Shannon Sterz wrote:
> On Tue May 6, 2025 at 3:26 PM CEST, Dominik Csapak wrote:
>> by first checking for `self.loading` since we don't have to iterate
>> over the wizard pages if that is true.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> src/wizard.rs | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/src/wizard.rs b/src/wizard.rs
>> index e33d3c6..16b1dd8 100644
>> --- a/src/wizard.rs
>> +++ b/src/wizard.rs
>> @@ -635,11 +635,11 @@ impl PwtWizard {
>> Some(key) => props.pages.get_index_of(key).unwrap_or(0),
>> };
>>
>> - let mut next_is_enabled = state.can_progress();
>> -
>> - if self.loading {
>> - next_is_enabled = false;
>> - }
>> + let next_is_enabled = if self.loading {
>> + false
>> + } else {
>> + state.can_progress()
>> + };
>
> couldn't this be more simply:
>
> let next_is_enabled = !self.loading && state.can_progress();
>
> i think that reads a bit more easily ("state isn't `loading` and we can
> progress").
>
true,, i'll send a v2
>>
>> let next_page = props
>> .pages
>
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel