From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 223041FF179 for ; Wed, 10 Dec 2025 10:32:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 832BD1593C; Wed, 10 Dec 2025 10:33:17 +0100 (CET) Message-ID: <353d830c-3872-4559-98d6-f6f7de8fa9de@proxmox.com> Date: Wed, 10 Dec 2025 10:32:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Dietmar Maurer , Yew framework devel list at Proxmox References: <20251209131159.4027954-1-dietmar@proxmox.com> <8a122ef5-39ab-4cc6-8744-869384f627fe@proxmox.com> <50dcf248-e5c0-4ecc-bc95-2ec0ae8a4690@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <50dcf248-e5c0-4ecc-bc95-2ec0ae8a4690@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765359157757 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [yew-devel] [RFC yew-comp] refactor: move LoadableComponent state into component implementations X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" Am 10.12.25 um 10:23 schrieb Dietmar Maurer: > > On 12/10/25 8:53 AM, Thomas Lamprecht wrote: >> Spotted another typo, and while checking that I found a parameter name a bit >> >> >> Am 09.12.25 um 15:36 schrieb Dietmar Maurer: >>> +pub struct LoadableComponentState { >>> + loading: usize, >>> + last_load_error: Option, >>> + repeat_timespan: u32, /* 0 => no repeated loading */ >> nit: repeat is IMO a bit generic for what this is used for and reads a tiny bit >> awkwardly to me as I do not recognize that as widely used term for these thing. >> Using timespan for interval or polling period feels also slightly odd. >> >> You could use "reload_interval", that's apt, telling and fits to the reload_timeout >> below. Adapting the repeated_load function to reload_interval (or set_reload_interval) >> would make it also a bit more telling IMO, as is, it's not as clear as it could be >> that this is a period for anybody not used to the code. > > Maybe we can defer that renaming after the structural changes got in? Sure, just thought it might be less churn now if you touch that much code anyway already it might not be that much extra work, but having it as separate change might indeed be nicer, so fine by me. > Anyways, I will send a v2 including the typo fixes. > > Also, Dominik found a way to avoid send_custom_message() and custom_callback(), > simply by implementing: > > > impl From for Msg { > fn from(value: M) -> Self { > Msg::ChildMessage(value) > } > } great, that's better! _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel