[PATCH yew-widget-toolkit 1/5] widget: data table: keep hidden columns when headers are recreated

[Dominik Csapak <d.csapak@proxmox.com>]

The data table resets the hidden state of all columns every time it
gets a new headers Rc, but the header widget keeps its state as long
as the column names don't change. Some callers create the headers in
their view function (e.g. the running tasks list in proxmox-yew-comp),
so the table gets a new Rc every time the parent renders.

This means that a column that was hidden via the header menu stays
hidden in the header, but is shown again in the rows, so the cells
don't match the header columns anymore.

To reproduce:
* use a data table where the parent creates the headers in its view
* hide a column via the header menu
* trigger a re-render of the parent, e.g. by changing its state

Fix this by using the same check as the header widget, and only reset
the hidden state when the column names change.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/widget/data_table/data_table.rs | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/src/widget/data_table/data_table.rs b/src/widget/data_table/data_table.rs
index 9407844..b7a3941 100644
--- a/src/widget/data_table/data_table.rs
+++ b/src/widget/data_table/data_table.rs
@@ -1067,13 +1067,20 @@ impl<S: DataStore> PwtDataTable<S> {
         for header in props.headers.iter() {
             header.extract_column_list(&mut columns);
         }
-        let mut column_hidden = Vec::new();
-        for column in columns.iter() {
-            column_hidden.push(column.hidden);
+        // Like the header widget, keep the hidden state while the column names stay the same.
+        // Callers sometimes recreate the headers on every render, and resetting it here would show
+        // columns in the rows that the user hid in the header.
+        let same_columns = self.columns.len() == columns.len()
+            && self
+                .columns
+                .iter()
+                .zip(columns.iter())
+                .all(|(old, new)| old.name == new.name);
+        if !same_columns {
+            self.column_hidden = Rc::new(columns.iter().map(|column| column.hidden).collect());
         }
         self.headers = Rc::new(headers);
         self.columns = Rc::new(columns);
-        self.column_hidden = Rc::new(column_hidden);
     }
 }
 
-- 
2.47.3